link: Recognize -Wl,-implib,foo.lib and pass it to LLD as /implib:foo.lib. #9251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know how decisions are made wrt what changes meet the bar for a patch release of Zig, but fwiw, this PR (and to a lesser extent #9222 and #9223) is blocking my work on zig-msbuild-sdk. So it would be great if this could make it into 0.8.1. |
|
I think support for the |
|
I think I like the approach in your PR better than using |
|
Closing in favor of #9347. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9210.
Note that this is just intended as a stopgap. The syntax isn't exactly the same as if you're working with
lld-linkdirectly, and we should probably think about doing this by default for DLLs.