Skip to content

refactor(#912): collapse resync serialization into the lifecycle mailbox #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zgeoff merged 4 commits into from
Aug 17, 2026
Merged

refactor(#912): collapse resync serialization into the lifecycle mailbox #943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6621141
refactor(#912): collapse resync serialization into the lifecycle mailbox
zgeoff Aug 17, 2026
5e9ac21
fix(#912): pin inline-resync window, drop test-body branching
zgeoff Aug 17, 2026
0a86630
fix(#912): land the external resync arrival mid-inline-flow
zgeoff Aug 17, 2026
34a1c13
refactor(#912): clear the resync ticket on any escape from its turn
zgeoff Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions libs/game/idle-client/src/test-utils/create-stub-worker-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { resolveServiceURL } from '@vers/mock-services';
import type { CheckpointSubmitter } from '../submission/create-checkpoint-submitter';
import type { ActivityServiceClient } from '../submission/types';
import type { RewardSlotLedgerEntry } from '../types';
import { createLifecycleMailbox } from '../worker/create-lifecycle-mailbox';
import type { WorkerContext } from '../worker/types';
import type { WorkerMessage } from '../worker/worker-to-client-message-schema';
import { createStubSubmitter } from './create-stub-submitter';
Expand Down Expand Up @@ -58,7 +59,6 @@ export function createStubWorkerContext(
let simulation: Simulation = createSimulation();
let activity: ActivityData | null = null;
let resyncAvatarID: string | null = null;
let resyncInFlight = false;
let rewardSlotLedgerActivityID: null | string = null;
let rewardSlotLedger: ReadonlyArray<RewardSlotLedgerEntry> = [];
let failureAction: ActivityFailureAction = options.failureAction ?? ActivityFailureAction.Abort;
Expand All @@ -70,8 +70,7 @@ export function createStubWorkerContext(

let cancelSignal = AbortSignal.any([stopController.signal, shutdownController.signal]);
let startToken: null | string = null;
let lifecycleTail: Readonly<Promise<void>> = Promise.resolve();
let queuedClaimResync: null | string = null;
const mailbox = createLifecycleMailbox();
let writerDisplacedActivityID: null | string = null;
let connectivityOnline = true;
const broadcasts: Array<WorkerMessage> = [];
Expand Down Expand Up @@ -102,15 +101,13 @@ export function createStubWorkerContext(
entries: rewardSlotLedger,
}),
getSimulation: () => simulation,
getLifecycleTail: () => lifecycleTail,
getQueuedClaimResync: () => queuedClaimResync,
getMailbox: () => mailbox,
getStartToken: () => startToken,
getStopSignal: () => stopController.signal,
getSubmitter: () => submitter,
getWriterDisplacedActivityID: () => writerDisplacedActivityID,
isFailureActionDirty: () => failureActionDirty,
isFailureActionPushInFlight: () => failureActionPushInFlight,
isResyncInFlight: () => resyncInFlight,
recordRewardSlots: (activityID, entry) => {
if (rewardSlotLedgerActivityID === activityID) {
rewardSlotLedger = [...rewardSlotLedger, entry];
Expand All @@ -137,18 +134,9 @@ export function createStubWorkerContext(
setFailureActionPushInFlight: (inFlight) => {
failureActionPushInFlight = inFlight;
},
setQueuedClaimResync: (avatarID) => {
queuedClaimResync = avatarID;
},
setResyncAvatarID: (avatarID) => {
resyncAvatarID = avatarID;
},
setResyncInFlight: (inFlight) => {
resyncInFlight = inFlight;
},
setLifecycleTail: (flow) => {
lifecycleTail = flow;
},
setStartToken: (token) => {
startToken = token;
},
Expand Down
Loading