Skip to content

Conversation

@geodem127
Copy link
Contributor

@geodem127 geodem127 commented Nov 7, 2025

RCA:

The search API was configured with an excessively high result limit (10,000) and no search term. This caused the request to fetch an unmanageably large dataset on page load, leading to frequent timeouts and failed responses.

FIX:

  • Removed the automatic API call on page load.
  • Implemented a debounced search that only triggers on valid user input.
  • Added sensible pagination/default limits to all search requests.
  • Refactored the logic to leverage the Redux store for efficient state management.
Loom.Message.-.7.November.2025.mp4

@geodem127 geodem127 force-pushed the fix/3873-search-api-crashing-issue branch from 436e0ea to fd78114 Compare November 7, 2025 13:37
@geodem127 geodem127 self-assigned this Nov 7, 2025
@geodem127 geodem127 linked an issue Nov 7, 2025 that may be closed by this pull request
@geodem127 geodem127 added the bug Something isn't working label Nov 7, 2025
@geodem127 geodem127 changed the base branch from dev to 607-live-domains-are-not-using-usedomain-logic-across-app November 10, 2025 11:15
@finnar-bin
Copy link
Contributor

@geodem127 is there any reason why the base branch has been changed? There's currently 300+ changed files

@geodem127 geodem127 changed the base branch from 607-live-domains-are-not-using-usedomain-logic-across-app to dev November 10, 2025 22:34
@geodem127
Copy link
Contributor Author

@geodem127 is there any reason why the base branch has been changed? There's currently 300+ changed files

I'm not sure what happened, but I’ve already switched it back to dev.

@geodem127 geodem127 requested a review from finnar-bin November 10, 2025 22:36
@shrunyan
Copy link
Contributor

Why is there so much code changed in the PR when the core of it, as descibed, is going from 10000 to 1000? i.e. I'm expecting a single line change PR.

no default search term.

Also not sure what that means. Why would search have a default term? How would we know what a baseline default term is that meets a users expectations.

@geodem127
Copy link
Contributor Author

Why is there so much code changed in the PR when the core of it, as descibed, is going from 10000 to 1000? i.e. I'm expecting a single line change PR.

no default search term.

Also not sure what that means. Why would search have a default term? How would we know what a baseline default term is that meets a users expectations.

The other modifications (debounce, filtering block items, and the UI icon) were initially part of the PR but have since been removed. The diff now primarily shows the core architectural change from RTK Query to Redux dispatch.

Just to clarify the RCA description: "no default search term" was a typo. It should read "no search term specified"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global search api call causes instances api service to crash

5 participants