Skip to content

Commit fd78114

Browse files
committed
Merge branch 'dev' into fix/3873-search-api-crashing-issue
2 parents c989f42 + 053d3c3 commit fd78114

File tree

7 files changed

+19
-45
lines changed

7 files changed

+19
-45
lines changed

etc/nginx.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ http {
3333
add_header X-Permitted-Cross-Domain-Policies "";
3434
add_header X-Frame-Options "deny";
3535
add_header Referrer-Policy "no-referrer-when-downgrade";
36-
add_header Content-Security-Policy "connect-src 'self' *.zesty.io *.a.run.app us-central1-zesty-dev.cloudfunctions.net us-central1-zesty-stage.cloudfunctions.net us-central1-zesty-prod.cloudfunctions.net *.sentry.io www.googleapis.com *.amplitude.com *.tiny.cloud *.getbynder.com *.bynder.com d8ejoa1fys2rk.cloudfront.net dam.redshieldtoolkit.org;";
36+
add_header Content-Security-Policy "connect-src 'self' *.zesty.io *.a.run.app us-central1-zesty-dev.cloudfunctions.net us-central1-zesty-stage.cloudfunctions.net us-central1-zesty-prod.cloudfunctions.net *.sentry.io www.googleapis.com *.amplitude.com *.tiny.cloud *.getbynder.com *.bynder.com d8ejoa1fys2rk.cloudfront.net dam.redshieldtoolkit.org brand.frontdoor.com;";
3737
# *.a.run.app - zesty cloudrun apps
3838
# d8ejoa1fys2rk.cloudfront.net - bynder modules
3939
# googleapis.com - google fonts

src/apps/content-editor/src/app/components/FieldTypeMedia.tsx

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ export const FieldTypeMedia = forwardRef(
8181
}: FieldTypeMediaProps,
8282
ref
8383
) => {
84-
const dndContainerRef = useRef(null);
8584
const [draggedIndex, setDraggedIndex] = useState<number | null>(null);
8685
const [hoveredIndex, setHoveredIndex] = useState<number | null>(null);
8786
const [localImageZUIDs, setLocalImageZUIDs] = useState<string[]>(images);
@@ -487,16 +486,14 @@ export const FieldTypeMedia = forwardRef(
487486
return (
488487
<>
489488
<Stack
490-
id={name}
491-
ref={dndContainerRef}
492489
data-cy="mediaItem-container"
493490
gap={1}
494491
sx={{
495492
border: (theme) =>
496493
hasError ? `1px solid ${theme.palette.error.main}` : "none",
497494
}}
498495
>
499-
<DndContextProvider containerRef={dndContainerRef}>
496+
<DndContextProvider>
500497
{sortedImages.map((image, index) => {
501498
const isBynderAsset = image?.includes("bynder.com");
502499

@@ -750,15 +747,11 @@ export const MediaItem = ({
750747
alignItems="center"
751748
sx={{
752749
border: (theme) => `1px solid ${theme.palette.border}`,
753-
borderRadius: "8px",
754-
"&:hover": {
755-
backgroundColor: "action.hover",
756-
cursor: "pointer",
757-
},
750+
borderRadius: 2,
758751
backgroundColor: "background.paper",
759-
...(isDragging && {
760-
opacity: 0.01,
761-
}),
752+
overflow: "hidden",
753+
opacity: isDragging ? 0 : 1,
754+
transform: "translate(0, 0)",
762755
}}
763756
position="relative"
764757
>

src/shell/components/DndContextProvider.tsx

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,14 @@
1-
import { memo, MutableRefObject, useEffect, useState } from "react";
1+
import { memo } from "react";
22
import { DndProvider } from "react-dnd";
33
import { HTML5Backend } from "react-dnd-html5-backend";
44

55
const DndContextProvider = memo(
6-
({
7-
containerRef,
8-
children,
9-
}: {
10-
containerRef: MutableRefObject<any>;
11-
children: React.ReactNode;
12-
}) => {
13-
const [context, setContext] = useState(null);
14-
15-
useEffect(() => {
16-
if (!containerRef?.current) return;
17-
setContext(containerRef?.current);
18-
}, [containerRef?.current]);
19-
20-
return context ? (
21-
<DndProvider backend={HTML5Backend} options={{ rootElement: context }}>
6+
({ children }: { children: React.ReactNode }) => {
7+
return (
8+
<DndProvider backend={HTML5Backend} context={window}>
229
{children}
2310
</DndProvider>
24-
) : null;
11+
);
2512
}
2613
);
2714

src/shell/components/GlobalSearch/index.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -196,15 +196,10 @@ export const GlobalSearch = () => {
196196

197197
const blocksSuggestions: Suggestion[] =
198198
blocks?.map((block) => {
199-
const langCode = languages?.find(
200-
(lang: Language) => lang?.ID === block?.langID
201-
)?.code;
202-
const titlePrefix = !!langCode ? `(${langCode}) ` : "";
203-
204199
return {
205200
type: "block",
206201
ZUID: block?.ZUID,
207-
title: block?.title, //`${titlePrefix}${block?.label}`,
202+
title: block?.title,
208203
updatedAt: block?.updatedAt,
209204
url: block?.url,
210205
};

src/shell/components/RelationalFieldBase/index.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import {
66
KeyboardArrowDownRounded,
77
AddRounded,
88
} from "@mui/icons-material";
9-
import { DndProvider } from "react-dnd";
10-
import { HTML5Backend } from "react-dnd-html5-backend";
119
import { useDispatch } from "react-redux";
1210

1311
import { ActiveItem } from "./ActiveItem";
@@ -21,6 +19,7 @@ import { ActiveItemLoading } from "./ActiveItem/ActiveItemLoading";
2119
import { CreateNewItemDialog } from "./CreateNewItemDialog";
2220
import { useParams } from "../../hooks/useParams";
2321
import { CreateContentItemDialogContext } from "../../contexts/CreateContentItemDialogProvider";
22+
import DndContextProvider from "../DndContextProvider";
2423

2524
type RelationalFieldBaseProps = {
2625
name: string;
@@ -121,7 +120,7 @@ export const RelationalFieldBase = ({
121120
<ActiveItemLoading key={index} draggable />
122121
))
123122
) : (
124-
<DndProvider backend={HTML5Backend}>
123+
<DndContextProvider>
125124
{itemZUIDs?.slice(0, showAll ? undefined : 5)?.map((val, index) => (
126125
<ActiveItem
127126
key={val}
@@ -146,7 +145,7 @@ export const RelationalFieldBase = ({
146145
}}
147146
/>
148147
))}
149-
</DndProvider>
148+
</DndContextProvider>
150149
)}
151150
</Stack>
152151
{itemZUIDs?.length > 5 && (

src/shell/hooks/useSearchBlocksByKeyword.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,6 @@ export const useSearchBlocksByKeyword = ({
186186
isLoading,
187187
variants,
188188
blocks,
189-
languages,
190-
users,
191189
normalizedSearchTerm,
192190
showAll,
193191
languageMap,
@@ -203,7 +201,9 @@ export const useSearchBlocksByKeyword = ({
203201
if (showAll && !!blocks?.length) {
204202
setIsFetchingVariants(true);
205203
Promise.all(
206-
blocks?.map((block) => dispatch(fetchItems(block?.ZUID)))
204+
blocks?.map((block) =>
205+
dispatch(fetchItems(block?.ZUID, { limit: 1000 }))
206+
)
207207
).then(() => {
208208
setIsFetchingVariants(false);
209209
});

src/shell/webpack.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ module.exports = async (env) => {
5555
},
5656
headers: {
5757
"Content-Security-Policy":
58-
"connect-src 'self' *.zesty.io *.a.run.app us-central1-zesty-dev.cloudfunctions.net us-central1-zesty-stage.cloudfunctions.net us-central1-zesty-prod.cloudfunctions.net *.sentry.io www.googleapis.com *.amplitude.com *.tiny.cloud *.getbynder.com *.bynder.com d8ejoa1fys2rk.cloudfront.net dam.redshieldtoolkit.org;",
58+
"connect-src 'self' *.zesty.io *.a.run.app us-central1-zesty-dev.cloudfunctions.net us-central1-zesty-stage.cloudfunctions.net us-central1-zesty-prod.cloudfunctions.net *.sentry.io www.googleapis.com *.amplitude.com *.tiny.cloud *.getbynder.com *.bynder.com d8ejoa1fys2rk.cloudfront.net dam.redshieldtoolkit.org brand.frontdoor.com;",
5959
// *.a.run.app - zesty cloudrun apps
6060
// d8ejoa1fys2rk.cloudfront.net - bynder modules
6161
// googleapis.com - google fonts

0 commit comments

Comments
 (0)