Sama7g5 USB UDC (UDPHS) driver #99620

MCHP-MPU-Solutions-SHA · 2025-11-19T01:57:54Z

Add driver support for Sama7g5 USB UDC (UDPHS).

Many thanks.
Xing.

tmon-nordic · 2025-11-19T09:55:58Z

drivers/usb/udc/Kconfig.mchp_sam

+	  USB packets system data bursts will be locked for
+	  maximum optimization of the bus bandwidth usage.


I have no idea what this really means. From code it seems that you set some bit. Is it essentially affecting DMA operation/memory access arbitrage?

Hi, this is a chip related feature, for more details please refer to the datasheet, see bit BURST_LCK in register UDPHS_DMACONTROL.
This will allow the UDPHS DMA channel has max burst length when accessing the bus.

And I made a switch for this feature in the Kconfig, customer can enable it for higher USB bandwidth under heavy system load.

nandojve

Add a report from sample/subsys/usb/testusb HS. FS is it should work like that too.
A full report usually tests from 0 up to 29.

nandojve · 2025-11-20T14:32:02Z

dts/arm/microchip/sam/sama7g5.dtsi

 			};
 		};
+
+		udphsa: usbd@200000 {


Convention is order by address.

The devices in sama7g5.dtsi have been listed in alphabetical order, so I put the udphs device at the end of it.
Do you still need me order the udphs devices by space address?

nandojve · 2025-11-20T14:35:33Z

dts/bindings/usb/microchip,sam-udc.yaml

+
+compatible: "microchip,sam-udphs"
+
+include: [usb-ep.yaml, pinctrl-device.yaml]


zephyr/dts/bindings/ethernet/atmel,gmac-common.yaml

Lines 5 to 7 in db0c34d

include:

- name: ethernet-controller.yaml

- name: pinctrl-device.yaml

-include: [usb-ep.yaml, pinctrl-device.yaml] +include: + - name: usb-ep.yaml + - name: pinctrl-device.yaml

nandojve · 2025-11-20T14:37:26Z

soc/microchip/sam/sama7g5/soc.c

 		   (MMU_REGION_FLAT_ENTRY("pwm", PWM_BASE_ADDRESS, 0x500,
 					  MT_STRONGLY_ORDERED | MPERM_R | MPERM_W),))

+	MMU_REGION_FLAT_ENTRY("rstc", RSTC_BASE_ADDRESS, 0x10,


by convention we are enabling this before devicetree binding. Move this commit to 2nd position.

Note: Adjust the commit message body to be close to the 72 character per line.

Commits order has been adjusted.
Commit message body has been adjusted.

nandojve · 2025-11-20T14:39:27Z

drivers/usb/udc/Kconfig.mchp_sam

+
+config UDC_MCHP_SAM_BURST_LOCK
+	bool "Lock bus access for maximum bandwidth"
+	default n


I think the default n can be dropped because it is the default. See redundant-defaults. Drop all redundant defaults.

All redundant defaults have been removed.

nandojve · 2025-11-20T14:43:37Z

drivers/usb/udc/udc_mchp_sam.c

+#define SZ_1024 10 /* 1 << 10 */
+};
+
+static const struct udphs_ep_desc sam_ep_desc[UDPHS_EPT_NUMBER] = {


By this table the driver will only expose HS, no FS. Is that right ?

No, this table exposed all endpoints for HS and FS.
These endpoints can be used in HS mode and FS mode.

Add api function to check the setup stage, which means the control transfer's stages are completed and back to the default stage. Signed-off-by: CHEN Xing <xing.chen@microchip.com>

Update mmu region for udphsa and udphsb, add usb phy clock configuration Signed-off-by: CHEN Xing <xing.chen@microchip.com>

Add udphsa udphsb udc devices to sama7g5 Signed-off-by: CHEN Xing <xing.chen@microchip.com>

Add driver for sama7g5 UDPHS Signed-off-by: CHEN Xing <xing.chen@microchip.com>

Add udphs udc devices and enable udphsa Signed-off-by: CHEN Xing <xing.chen@microchip.com>

sonarqubecloud · 2025-11-24T07:07:46Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

MCHP-MPU-Solutions-SHA · 2025-11-24T09:54:05Z

Add a report from sample/subsys/usb/testusb HS. FS is it should work like that too. A full report usually tests from 0 up to 29.

Hi Gerson,
It looks like I have find a driver bug via testusb tool (in test 10), so I just remove the previous comment.
I will fix it and updated here.

Many thanks.
Xing.

nandojve · 2025-11-24T17:26:30Z

Add a report from sample/subsys/usb/testusb HS. FS is it should work like that too. A full report usually tests from 0 up to 29.

Hi Gerson, It looks like I have find a driver bug via testusb tool (in test 10), so I just remove the previous comment. I will fix it and updated here.

Many thanks. Xing.

If I'm not mistake, 10 is about data out in control EP. The below could give you some hints.
Make sure you have the correct EP size too.
68b57ea

zephyrbot added platform: Microchip MEC Microchip MEC Platform area: USB Universal Serial Bus area: Devicetree Bindings area: Boards/SoCs platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Nov 19, 2025

zephyrbot requested review from ArunMCHP, VenkatKotakonda, albertofloyd, jfischer-no, josuah, jvasanth1, nandojve, pdgendt, stephanosio and tmon-nordic November 19, 2025 01:59

zephyrbot assigned jfischer-no Nov 19, 2025

tmon-nordic reviewed Nov 19, 2025

View reviewed changes

MCHP-MPU-Solutions-SHA force-pushed the sama7g5_udphs branch 2 times, most recently from 347563c to 5a56317 Compare November 20, 2025 07:08

nandojve added this to the v4.4.0 milestone Nov 20, 2025

nandojve requested changes Nov 20, 2025

View reviewed changes

MCHP-MPU-Solutions-SHA added 5 commits November 24, 2025 14:19

drivers: usb: udc: add api for check setup stage

d38fa7d

Add api function to check the setup stage, which means the control transfer's stages are completed and back to the default stage. Signed-off-by: CHEN Xing <xing.chen@microchip.com>

soc: microchip: sam: sama7g5: update mmu for udphs

c1436ca

Update mmu region for udphsa and udphsb, add usb phy clock configuration Signed-off-by: CHEN Xing <xing.chen@microchip.com>

dts: arm: microchip: sam: add udc device to sama7g5

f48040f

Add udphsa udphsb udc devices to sama7g5 Signed-off-by: CHEN Xing <xing.chen@microchip.com>

driver: usb: udc: add support for sama7g5 UDPHS

a2d92b8

Add driver for sama7g5 UDPHS Signed-off-by: CHEN Xing <xing.chen@microchip.com>

boards: microchip: sam: sama7g54_ek: enable udc device

9ca0f9a

Add udphs udc devices and enable udphsa Signed-off-by: CHEN Xing <xing.chen@microchip.com>

MCHP-MPU-Solutions-SHA force-pushed the sama7g5_udphs branch from 5a56317 to 9ca0f9a Compare November 24, 2025 06:40

MCHP-MPU-Solutions-SHA requested a review from nandojve November 24, 2025 06:41

		USB packets system data bursts will be locked for
		maximum optimization of the bus bandwidth usage.


		compatible: "microchip,sam-udphs"

		include: [usb-ep.yaml, pinctrl-device.yaml]

	include:
	- name: ethernet-controller.yaml
	- name: pinctrl-device.yaml

Sama7g5 USB UDC (UDPHS) driver #99620

Are you sure you want to change the base?

Sama7g5 USB UDC (UDPHS) driver #99620

Conversation

MCHP-MPU-Solutions-SHA commented Nov 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nandojve left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 24, 2025

Quality Gate passed

Uh oh!

MCHP-MPU-Solutions-SHA commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nandojve commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MCHP-MPU-Solutions-SHA commented Nov 24, 2025 •

edited

Loading