MAINTAINERS: Update filter for NXP Xtensa platform #90947
Conversation
Add new filters for Xtensa platforms: * imxrt7xx supports now a hifi1 core * imxrt6xx/imxrt7xx support now a hifi4 core Kconfig* and CMakeList.txt files could be updated for Xtensa related code so add them to the filters too. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
|
| - soc/nxp/imxrt/imxrt7xx/hifi1/ | ||
| - soc/nxp/imxrt/*/hifi4/ | ||
| - soc/nxp/imxrt/imxrt(5|6|7)xx/CMakeLists.txt | ||
| - soc/nxp/imxrt/imxrt(5|6|7)xx/Kconfig* |
There was a problem hiding this comment.
I'm okay with this but you realize now any change to the CMakeLists.txt and Kconfig files will cause the PR to match Xtensa. Even if they are items related to the Arm core.
There was a problem hiding this comment.
Is that not normal for maintainer areas? I get requested to like 50 PRs per day that I have no interest in reviewing due to not being interested in every single line of code in all the files in the areas I am on.
In this case the issue is that right now changes to this file matches the group for the arm cores even if the changes only has to do with xtensa. And we have to notice this and remember to add the xtensa reviewers manually to review those changes.
There was a problem hiding this comment.
I'm okay with this but you realize now any change to the CMakeLists.txt and Kconfig files will cause the PR to match Xtensa. Even if they are items related to the Arm core.
I think that's fine. We are mostly keeping an eye on the other platforms too.
Add new filters for Xtensa platforms:
* imxrt7xx supports now a hifi1 core
* imxrt6xx/imxrt7xx support now a hifi4 core
Kconfig* and CMakeList.txt files could be updated for Xtensa related code so add them to the filters too.