Skip to content

MAINTAINERS: Update filter for NXP Xtensa platform #90947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MAINTAINERS: Update filter for NXP Xtensa platform #90947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions MAINTAINERS.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3945,6 +3945,10 @@ NXP Platforms (Xtensa):
files:
- soc/nxp/imx/*/adsp/
- soc/nxp/imxrt/imxrt5xx/f1/
- soc/nxp/imxrt/imxrt7xx/hifi1/
- soc/nxp/imxrt/*/hifi4/
- soc/nxp/imxrt/imxrt(5|6|7)xx/CMakeLists.txt
- soc/nxp/imxrt/imxrt(5|6|7)xx/Kconfig*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this but you realize now any change to the CMakeLists.txt and Kconfig files will cause the PR to match Xtensa. Even if they are items related to the Arm core.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that not normal for maintainer areas? I get requested to like 50 PRs per day that I have no interest in reviewing due to not being interested in every single line of code in all the files in the areas I am on.

In this case the issue is that right now changes to this file matches the group for the arm cores even if the changes only has to do with xtensa. And we have to notice this and remember to add the xtensa reviewers manually to review those changes.

Copy link
Collaborator Author

@dbaluta dbaluta Jun 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this but you realize now any change to the CMakeLists.txt and Kconfig files will cause the PR to match Xtensa. Even if they are items related to the Arm core.

I think that's fine. We are mostly keeping an eye on the other platforms too.

labels:
- "platform: NXP Xtensa"
description: NXP Xtensa platforms
Expand Down
Loading