boards: silabs: Add support for Silabs EFR32ZG28 SoC #89597
Conversation
|
Hello @shontal1005, and thank you very much for your first pull request to the Zephyr project! |
github-actions
bot
added
area: Pinctrl
area: Clock Control
platform: Silabs
github-actions
bot
requested review from
asmellby,
gmarull,
jerome-pouiller,
jhedberg,
Martinhoff-maker,
mnkp,
nordic-krch,
rettichschnidi and
yonsch
There was a problem hiding this comment.
this is missing a documentation page
see https://github.com/zephyrproject-rtos/zephyr/blob/76e1fc7713a4a3f2b50c497afddec0364a34c10b/doc/templates/board.tmpl or other SiLabs boards for examples
Thanks!
|
The commit is large. Would you mind to split it in two parts (or more)? Maybe one commit for the soc and one commit for the board? BTW, don't this PR require any change on the hal? If yes, you need to update |
dts/arm/silabs/efr32xg28.dtsi
Outdated
| compatible = "fixed-factor-clock"; | ||
| clocks = <&lfrco>; | ||
| }; | ||
| wdog0clk: wdog0clk { |
There was a problem hiding this comment.
peripherals need to be disabled in the base dts file, then enabled as-needed by boards
There was a problem hiding this comment.
It seems that on all other platforms the peripherals are not disabled
| config SOC_GECKO_SDID | ||
| default 235 if SOC_SERIES_EFR32ZG28 |
There was a problem hiding this comment.
if this is an existing symbol, put it in Kconfig.defconfig
There was a problem hiding this comment.
I don't understand, it seems like all the other platforms do the same thing as I did
There was a problem hiding this comment.
Then they need to move Kconfig adds new symbols, if you are changing the default of an existing symbol then it goes in Kconfig.defconfig
There was a problem hiding this comment.
@shontal1005, do you want to carry this change or you prefer I open a PR?
There was a problem hiding this comment.
If the change I made is what you meant, I can open another PR.
github-actions
bot
added
area: UART
shontal1005
force-pushed
the
main
branch
3 times, most recently
from
38254e0 to
f52e20c
Compare
Add support for Silicon Labs EFR32ZG28 SoC. Signed-off-by: Shontal Biton <shontal1005@gmail.com>
Add support for Silicon Labs BRD4401C (a.k.a xG28-RB4401C) Radio Board. Signed-off-by: Shontal Biton <shontal1005@gmail.com>
Added support for xg28 in eeprom test. Signed-off-by: Shontal Biton <shontal1005@gmail.com>
|
| Silicon Labs EFM32PG28 Series MCU | ||
| Silicon Labs EFR32ZG28 Series MCU | ||
|
|
||
| config SOC_SILABS_XG28 |
There was a problem hiding this comment.
Why did you move this symbol? Following the principle of declaration before use, it should stay at the top of the file. By moving this, you are also introducing an unnecessary diff that makes it harder to review the PR.
| @@ -185,7 +186,9 @@ | |||
| pstate_em1: em1 { | |||
| compatible = "zephyr,power-state"; | |||
| power-state-name = "runtime-idle"; | |||
| min-residency-us = <4>; | |||
There was a problem hiding this comment.
These still need to be removed, see previous thread.
Adds support for Silicon Labs EFR32ZG28 SoC and BRD4401C Radio Board.