Skip to content

Added EFR32xG28 device #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shontal1005
Copy link

@shontal1005 shontal1005 commented May 13, 2025

Add hal support for the EFR32xG28 Silicon Labs device

@jhedberg
Copy link
Member

@shontal1005 thanks for the PR! However, please follow the same commit message (and PR description) guidelines as for the main tree. Also, please follow the steps documented here to reference this PR from your main tree PR: https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules

@asmellby
Copy link
Collaborator

I'm wondering if it would be better to build upon PR #95 for this, it already adds FG28 and does all the common things for xG28, so extending to ZG28 would be an incremental change. The reason it's not merged yet is that there is no corresponding main tree PR to demonstrate that it doesn't break existing devices.

@janchri
Copy link
Contributor

janchri commented May 14, 2025

fyi: I am bit struggeling on enabling the UART shell on the PG23 devKit. For PG28 DevKit everything seems to work fine.

@shontal1005
Copy link
Author

For some reason the module.yml isn't getting updated to include the xg28 blobs. Can I get any help with this?

@jhedberg
Copy link
Member

jhedberg commented Jul 3, 2025

For some reason the module.yml isn't getting updated to include the xg28 blobs. Can I get any help with this?

The answer should be somewhere in the scripts/update_simplicity_sdk.py script. It seems to me like it's designed to only update platforms that are already part of module.yml, so perhaps you need to manually create an entry there for xg28 and then run the script to update it once more?

@asmellby
Copy link
Collaborator

This PR needs to be rebased now that #95 has been merged.

@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch 3 times, most recently from 09a0d97 to cf46d45 Compare July 30, 2025 18:29
@jerome-pouiller
Copy link
Collaborator

Hello @shontal1005,

This PR has to be reworked in order to be merged:

@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch 3 times, most recently from 4be0163 to a6effa0 Compare August 4, 2025 07:13
Copy link
Collaborator

@asmellby asmellby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up the git commits, where the first commit changes the import script to add ZG28 (and potentially FG28), and the next commit adds the device files from SiSDK. You will also need to add the efr32xg28 RAIL and BT libraries to module.yml.

@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch 4 times, most recently from 4d523a0 to 617c42b Compare August 4, 2025 09:42
@jerome-pouiller
Copy link
Collaborator

Commit simplicity_sdk: Add SDK files for the EFR32xG28 modules has to follow:
https://docs.zephyrproject.org/latest/contribute/guidelines.html#identifying-contribution-origin
(see also other commits in this repo)

scripts/import_simplicity_sdk.py has to reference ZG28 files.

@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch 2 times, most recently from 3c0515e to 0d0bc82 Compare August 6, 2025 16:15
Added the commands required for importing the source and header files for the EFR32ZG28.

Signed-off-by: Shontal Biton <shontal1005@gmail.com>
Origin: Simplicity SDK
License: Zlib
URL: https://github.com/SiliconLabs/simplicity_sdk
Commit: 4c4c7151c8a5953a6afc1e926c0bbb9e4e1893de
Version: 2025.6.1
Purpose: Add support for EFR32ZG28 modules.

Signed-off-by: Shontal Biton <shontal1005@gmail.com>
@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch from 0d0bc82 to 46f1bbd Compare August 6, 2025 16:31
@shontal1005 shontal1005 requested a review from asmellby August 6, 2025 16:33
@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch from 46f1bbd to 838a664 Compare August 7, 2025 08:24
@shontal1005 shontal1005 requested a review from asmellby August 7, 2025 08:25
@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch from 838a664 to 6e08396 Compare August 7, 2025 10:50
Add the RAIL blobs for EFR32xG28.

Signed-off-by: Shontal Biton <shontal1005@gmail.com>
@shontal1005 shontal1005 force-pushed the Adding-EFR32xG23-device branch from 6e08396 to 2db7514 Compare August 10, 2025 11:17
@shontal1005 shontal1005 requested a review from asmellby August 10, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants