arch: arm: fix ci failure #87965
Merged
arch: arm: fix ci failure #87965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix ci failure caused by commit d5d4d57 In the above commit, it's wrongly assumed that ROM_ADDR and RAM_ADDR are same **only** when CONFIG_XIP is not defined. Since aarch64 was taken as reference in the review, we missed to see that CONFIG_FLASH_SIZE is also part of the condition to define ROM_ADDR as RAM_ADDR. CONFIG_XIP is not defined for qemu_cortex_a9/xc7z007s however, CONFIG_FLASH_SIZE is not 0 so the assumption fails and the required reset to RAM_ADDR is not applied leading to the test failure. Signed-off-by: Sudan Landge <sudan.landge@arm.com>
github-actions
bot
requested review from
MaureenHelm,
bbolen,
carlocaione,
dcpleung,
galak,
ithinuel,
microbuilder,
nashif and
stephanosio
kartben
added
the
Hotfix
nashif
approved these changes
Apr 1, 2025
nhutnguyenkc
approved these changes
Apr 1, 2025
kartben
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix ci failure caused by commit d5d4d57
In the above commit, it's wrongly assumed that ROM_ADDR and RAM_ADDR are same only when CONFIG_XIP is not defined.
Since aarch64 was taken as reference in the review, we missed to see that CONFIG_FLASH_SIZE is also part of the condition to define ROM_ADDR as RAM_ADDR.
CONFIG_XIP is not defined for qemu_cortex_a9/xc7z007s however, CONFIG_FLASH_SIZE is not 0 so the assumption fails and the required reset to RAM_ADDR is not applied leading to the test failure.