NXP LPSPI: Add support for Peripheral (slave) mode #87144
+283
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
platform: NXP
zephyrbot
requested review from
butok,
dbaluta,
dleach02,
EmilioCBen,
manuargue,
mmahadevan108,
Raymond0225,
tbursztyka and
teburd
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
decsny
force-pushed
the
feature/lpspi_slave
branch
from
67f58c1 to
8ee79a0
Compare
If there are HAL definitions available, do these two things: Ungate the clock for the device from the zephyr driver. Eventually it would be better to have a clocks property in the LPSPI DT node and get the resources from there rather than the HAL. Some platforms require the peripheral to be reset at system level, add code to do this. Eventually it would be more ideal to have Zephyr reset drivers for all of the NXP platforms and use DT to describe the reset resources, but for now we can just do this to get the LPSPI supported. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Optimize the TX fill algorithm to have less interrupts by filling the TX fifo as much as possible during each interrupt handle. Before, the algorithm was just a very simple, fill the TX fifo with as much from only the current buffer as possible, then send it and wait for the next interrupt. Now the algorithm is to fill the TX fifo as much as possible, even if it means reading from multiple buffers during the interrupt. This has the advantage from master mode of having less interrupts. And it is very important for slave mode because the slave mode does not control the pacing of the transfer and so therefore should fill as much as possible whenever possible in order not to miss a deadline. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add basic support for basic peripheral mode operation. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add overlay for a reworked board that breaks out LPSPI1 to the arduino header. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
Add an overlay to the spi_controller_peripheral test for the frdm_mcxa156. Since this IP has multiple CS, need to introduce a way to configure the correct CS to the test; just going to use zephyr,user for now instead of refactoring to be less nordic-specific, keeping the usage optional. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
decsny
force-pushed
the
feature/lpspi_slave
branch
from
8ee79a0 to
513dc46
Compare
EmilioCBen
reviewed
Mar 20, 2025
| @@ -9,6 +9,49 @@ LOG_MODULE_REGISTER(spi_mcux_lpspi_common, CONFIG_SPI_LOG_LEVEL); | |||
|
|
|||
| #include "spi_nxp_lpspi_priv.h" | |||
|
|
|||
| #if defined(LPSPI_RSTS) || defined(LPSPI_CLOCKS) | |||
There was a problem hiding this comment.
What file would these be defined in?
There was a problem hiding this comment.
in fsl_clock.h and fsl_reset.h in the HAL, eventually long term want to use DT instead of HAL driver definitions
EmilioCBen
approved these changes
Mar 20, 2025
|
put DNM because there are some timing issues with CPHA=0, need to debug |
| peripheral-cs = <1>; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
It would be useful for testing if you could include the connection setup in a comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Peripheral mode into the NXP LPSPI interrupt-based driver.
So far, it is only tested on MCXA156, but this is a great start because due to the small fifo, it is probably the most difficult to enable on.