tests: Bluetooth: Tester: VCP BSIM test #86664
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bttester_bsim_vcp
branch
5 times, most recently
from
3532311 to
b817f40
Compare
Thalley
force-pushed
the
bttester_bsim_vcp
branch
3 times, most recently
from
12dd064 to
44c4b1b
Compare
Thalley
force-pushed
the
bttester_bsim_vcp
branch
3 times, most recently
from
9e0b85c to
1aa846b
Compare
Thalley
force-pushed
the
bttester_bsim_vcp
branch
from
1aa846b to
a87222f
Compare
Thalley
force-pushed
the
bttester_bsim_vcp
branch
from
a87222f to
d8f12f3
Compare
There was a problem hiding this comment.
Copilot reviewed 14 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (12)
- tests/bluetooth/tester/Kconfig.sysbuild: Language not supported
- tests/bluetooth/tester/boards/nrf52_bsim.conf: Language not supported
- tests/bluetooth/tester/boards/nrf52_bsim.overlay: Language not supported
- tests/bluetooth/tester/boards/nrf5340bsim_nrf5340_cpuapp.conf: Language not supported
- tests/bluetooth/tester/boards/nrf5340bsim_nrf5340_cpuapp.overlay: Language not supported
- tests/bsim/bluetooth/compile.nrf5340bsim_nrf5340_cpuapp.sh: Language not supported
- tests/bsim/bluetooth/compile.sh: Language not supported
- tests/bsim/bluetooth/tester/CMakeLists.txt: Language not supported
- tests/bsim/bluetooth/tester/Kconfig: Language not supported
- tests/bsim/bluetooth/tester/boards/nrf52_bsim.overlay: Language not supported
- tests/bsim/bluetooth/tester/compile.sh: Language not supported
- tests/bsim/bluetooth/tester/prj.conf: Language not supported
Thalley
force-pushed
the
bttester_bsim_vcp
branch
2 times, most recently
from
e48ab9f to
43accc8
Compare
github-actions
bot
added
platform: nRF BSIM
github-actions
bot
requested review from
aescolar,
alwa-nordic,
cvinayak,
hermabe and
jhedberg
github-actions
bot
requested review from
MaureenHelm,
nashif,
rugeGerritsen,
sjanc,
stephanosio and
theob-pro
Thalley
requested review from
larsgk,
fredrikdanebjer,
asbjornsabo,
pin-zephyr and
niym-ot
and removed request for
theob-pro
Thalley
commented
Apr 8, 2025
There was a problem hiding this comment.
Looks like the change to this file does not apply when assigning reviewers and labels
There was a problem hiding this comment.
Correct. Only the maintainers file owner itself is notified.
There was a problem hiding this comment.
That's pretty interesting, because that means there's a chicken-and-egg situation here, right?
We cannot files to MAINTAINERS.yml before they exist, and the file isn't applied when added together :)
It's not a big issue, but was a bit surprising as generally changes to files in a PR is applied to CI
Thalley
force-pushed
the
bttester_bsim_vcp
branch
from
43accc8 to
c5a3ce4
Compare
Thalley
force-pushed
the
bttester_bsim_vcp
branch
3 times, most recently
from
dc4169f to
e22626d
Compare
Adds BSIM testing of the VCP features of the BT Tester. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bttester_bsim_vcp
branch
from
e22626d to
6e122cf
Compare
|
niym-ot
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds BSIM testing of the VCP features of the BT Tester.
Part of #86073