tests: Bluetooth: Add BT Tester GAP smoke test #86146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bttester_bsim
branch
5 times, most recently
from
78d85c5 to
65746a7
Compare
Thalley
force-pushed
the
bttester_bsim
branch
3 times, most recently
from
3bdaa4a to
f55cd0b
Compare
Thalley
commented
Mar 3, 2025
| @@ -87,6 +87,8 @@ | |||
|
|
|||
| #define BTP_STATUS_VAL(err) (err) ? BTP_STATUS_FAILED : BTP_STATUS_SUCCESS | |||
|
|
|||
| #define BTP_EVENT_OPCODE 0x80 | |||
There was a problem hiding this comment.
Comment on lines
55
to
57
| static inline void btp_gap_start_advertising(uint8_t adv_data_len, uint8_t scan_rsp_len, | ||
| const uint8_t adv_sr_data[], uint32_t duration, | ||
| uint8_t own_addr_type) |
There was a problem hiding this comment.
For reviewers: Should we define btp_gap.h and others, rather than a single large btp.h file? For now it's assumed that it's going to be a fairly limited amount of commands and events, and not the entire BTP
Thalley
force-pushed
the
bttester_bsim
branch
4 times, most recently
from
56306a6 to
fc00295
Compare
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
aescolar,
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen,
sjanc and
theob-pro
aescolar
reviewed
Mar 4, 2025
Thalley
commented
Mar 4, 2025
Thalley
force-pushed
the
bttester_bsim
branch
2 times, most recently
from
8ea0378 to
aced5a6
Compare
jhedberg
previously approved these changes
Mar 24, 2025
|
Fixed build error |
Thalley
force-pushed
the
bttester_bsim
branch
2 times, most recently
from
53c0d9a to
12fba65
Compare
jhedberg
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Copilot reviewed 9 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (13)
- tests/bluetooth/tester/Kconfig.sysbuild: Language not supported
- tests/bluetooth/tester/boards/nrf52_bsim.conf: Language not supported
- tests/bluetooth/tester/boards/nrf52_bsim.overlay: Language not supported
- tests/bluetooth/tester/boards/nrf5340bsim_nrf5340_cpuapp.conf: Language not supported
- tests/bluetooth/tester/boards/nrf5340bsim_nrf5340_cpuapp.overlay: Language not supported
- tests/bsim/bluetooth/compile.nrf5340bsim_nrf5340_cpuapp.sh: Language not supported
- tests/bsim/bluetooth/compile.sh: Language not supported
- tests/bsim/bluetooth/tester/CMakeLists.txt: Language not supported
- tests/bsim/bluetooth/tester/Kconfig: Language not supported
- tests/bsim/bluetooth/tester/boards/nrf52_bsim.overlay: Language not supported
- tests/bsim/bluetooth/tester/compile.sh: Language not supported
- tests/bsim/bluetooth/tester/prj.conf: Language not supported
- tests/bsim/bluetooth/tester/tests_scripts/gap.sh: Language not supported
Comments suppressed due to low confidence (1)
tests/bsim/bluetooth/tester/src/host/gap_peripheral.c:51
- The test description for the gap_peripheral test mentions 'GAP central' instead of 'GAP peripheral'. Please update the description to accurately reflect the test case.
.test_descr = "Smoketest for the GAP central BT Tester behavior",
jhedberg
previously approved these changes
Apr 7, 2025
Add a babblesim test of the BT Tester doing a GAP smoke test connecting 2 BT testers using BTP. The purpose of this is to further increase the test coverage of the BT Tester in CI, as it is only being built, and runtime errors are typically not caught. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
There was a problem hiding this comment.
Copilot reviewed 9 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (13)
- tests/bluetooth/tester/Kconfig.sysbuild: Language not supported
- tests/bluetooth/tester/boards/nrf52_bsim.conf: Language not supported
- tests/bluetooth/tester/boards/nrf52_bsim.overlay: Language not supported
- tests/bluetooth/tester/boards/nrf5340bsim_nrf5340_cpuapp.conf: Language not supported
- tests/bluetooth/tester/boards/nrf5340bsim_nrf5340_cpuapp.overlay: Language not supported
- tests/bsim/bluetooth/compile.nrf5340bsim_nrf5340_cpuapp.sh: Language not supported
- tests/bsim/bluetooth/compile.sh: Language not supported
- tests/bsim/bluetooth/tester/CMakeLists.txt: Language not supported
- tests/bsim/bluetooth/tester/Kconfig: Language not supported
- tests/bsim/bluetooth/tester/boards/nrf52_bsim.overlay: Language not supported
- tests/bsim/bluetooth/tester/compile.sh: Language not supported
- tests/bsim/bluetooth/tester/prj.conf: Language not supported
- tests/bsim/bluetooth/tester/tests_scripts/gap.sh: Language not supported
Comments suppressed due to low confidence (1)
tests/bsim/bluetooth/tester/src/bsim_btp.h:73
- The same parameter 'adv_sr_data' is used for both advertisement data and scan response data, which might be unintended if separate payloads are required. Consider using distinct parameters if different data should be transmitted.
if (adv_data_len > 0U) {
jhedberg
approved these changes
Apr 7, 2025
sjanc
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a babblesim test of the BT Tester doing a GAP smoke test connecting 2 BT testers using BTP.
The purpose of this is to further increase the test coverage of the BT Tester in CI, as it is only being built, and runtime errors are typically not caught.
fixes #86058