samples: fade_led: fix build error when PWM is not enabled #85281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some boards may define LEDs but disable them by default due to conflicts with other peripherals. In this case, the new sample code introduced in a5fd92b ("samples: fade_led: use all available LEDs") fails to build with a missing symbol error. Fix this by checking if the PWM device (the parent of the LED alias) is enabled before using it. This implicitly discards invalid aliases. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
pillo79
added
the
Hotfix
soburi
approved these changes
Feb 6, 2025
Member
soburi
left a comment
soburi
left a comment
There was a problem hiding this comment.
It seems that we were lax in our check. I'm sorry. Thank you.
kartben
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Arduino Nano 33 BLE defines a PWM LED whose controller is disabled by default due to conflicts with other peripherals:
zephyr/boards/arduino/nano_33_ble/arduino_nano_33_ble-common.dtsi
Lines 66 to 75 in 8df1591
In this case, the new sample code introduced in a5fd92b fails to build with a missing symbol error because it assumes defined nodes are usable.
Fix this by checking in the sample if the PWM device (the parent of the LED alias) is enabled before using it. This implicitly discards invalid aliases, as before.