Arduino nano 33 ble corrections

[KurtE]

Some minor fixes/changes to the Arduino Nano 33 BLE board definitions as well as to
by default, turn the Power LED on.

The main change in this PR is to update the arduino_nano_r3_connctor.dtsi file to fix the
mappings of several pins (7, 8, 18, 19, 21) to match the hardware.

Thanks
Kurt

[github-actions]

Hello @KurtE, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

[facchinm]

Checked with https://docs.arduino.cc/resources/pinouts/ABX00030-full-pinout.pdf , fixes are consistent

[kartben]

@KurtE there's a bug in boards/arduino/nano_33_ble/arduino_nano_33_ble_nrf52840_sense.yaml, unrelated to your PR, could you please fix the identifier: in a first commit?

diff --git a/boards/arduino/nano_33_ble/arduino_nano_33_ble_nrf52840_sense.yaml b/boards/arduino/nano_33_ble/arduino_nano_33_ble_nrf52840_sense.yaml
index a90550ce8f1..56f57856eef 100644
--- a/boards/arduino/nano_33_ble/arduino_nano_33_ble_nrf52840_sense.yaml
+++ b/boards/arduino/nano_33_ble/arduino_nano_33_ble_nrf52840_sense.yaml
@@ -1,4 +1,4 @@
-identifier: arduino_nano_33_ble//sense
+identifier: arduino_nano_33_ble/nrf52840/sense
 name: Arduino Nano 33 BLE Sense
 type: mcu
 arch: arm

also please check errors reported by the compliance check script to make your commits messages compliant :) thanks!
https://github.com/zephyrproject-rtos/zephyr/actions/runs/13012669945/job/36294212160?pr=84675

[pillo79]

Hello @KurtE and thanks for this.
Still a very tiny issue required to make CI happy - try signing off your commit as Kurt E maybe?

You can also run compliance checks locally with ./scripts/ci/check-compilance.py from the zephyr/ directory, if you wish. Make sure to run pip install -r scripts/requirements-compliance.txt once to get required packages though.

[KurtE]

Thanks @pillo79 - I thought I did, the commit was amended showing my Full name...
Yet it keeps mentioning the original post, I put in the signed off...

Will try it locally as you mentioned.

Thanks

[pillo79]

No worries, Benjamin just did it for you this time 😉 (thanks!)

EDIT: In fact, I think you already did. Might have been related to a CI glitch in the past days where PRs got stuck until you force pushed them once. Sorry about that ... see notes by Ben 🙂

[KurtE]

Thanks

[kartben]

No worries :)
For the record, the git command is:

git commit --amend --author="Jane Doe <jane@doe.com>" --no-edit

[kartben]

Thanks @pillo79 - I thought I did, the commit was amended showing my Full name...

@KurtE
ya the issue was the mismatch with the sign-off which you have correctly fixed, but git author that was not matching

thanks for your perseverance!

[pillo79]

... aaand a different issue appeared yesterday 😅
Not your PR's fault, but there is a problem with the Nano 33 BLE in the main branch right now. We will have to wait until #85281 is merged before retrying the CI. Sorry!

[github-actions]

Hi @KurtE!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁