wifi: nrf_wifi: extract NRF70_SYSTEM_WITH_RAW_MODES
#84350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jukkar,
Kludentwo,
krish2718,
MaochenWang1,
rlubos and
sachinthegreen
`NRF70_SYSTEM_WITH_RAW_MODES` is more accurately described as an additional option on top of `NRF70_SYSTEM_MODE`, not as a unique choice of `NRF70_OPER_MODES`. This allows the elimination of multiple `NRF70_SYSTEM_MODE || NRF70_SYSTEM_WITH_RAW_MODES` dependencies. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
force-pushed
the
250122_nrf_wifi_raw
branch
from
530a012 to
ed053e3
Compare
jukkar
previously approved these changes
Jan 22, 2025
This symbol now has the same meaning as `NRF70_SYSTEM_MODE`. Signed-off-by: Jordan Yates <jordan@embeint.com>
|
While reviewing the follow on I found that |
krish2718
approved these changes
Jan 22, 2025
rlubos
approved these changes
Jan 22, 2025
jukkar
approved these changes
Jan 23, 2025
MaochenWang1
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NRF70_SYSTEM_WITH_RAW_MODESis more accurately described as an additional option on top ofNRF70_SYSTEM_MODE, not as a unique choice ofNRF70_OPER_MODES.This allows the elimination of multiple
NRF70_SYSTEM_MODE || NRF70_SYSTEM_WITH_RAW_MODESdependencies.