drivers: wifi: options for application usage of Wi-Fi #84353

JordanYates · 2025-01-22T03:00:37Z

The CONFIG_WIFI symbol currently covers a number of different use-cases of Wi-Fi, primarily:

Wi-Fi AP (Broadcasting a network others can connect to)
Wi-Fi Station (Connecting to an AP + SSID scanning)
Wi-Fi AP + Station (Both the above)
Wi-Fi SSID scanning (SSID scanning only)

Each of these application usages of Wi-Fi requires a different set of supporting options to operate correctly (WPA_SUPP, NET_CONNECTION_MANAGER, etc), and different opportunities for resource optimization (System heap, buffer counts, etc).

Currently, optimizing the Wi-Fi drivers depends on driver specific options, which can be challenging to find and are obviously not portable across different drivers.

The addition of this choice allows applications to specify in a single Kconfig option which features of Wi-Fi they use, and enable individual Wi-Fi drivers to choose defaults based on those features.

Looking for initial feedback before documentation updates.

Includes the commit from #84350.

krish2718 · 2025-01-22T07:05:10Z

drivers/wifi/nrf_wifi/Kconfig.nrfwifi

@@ -40,15 +40,16 @@ config NRF70_QSPI_LOW_POWER

 choice NRF70_OPER_MODES
 	bool "nRF70 operating modes"
-	default NRF70_SYSTEM_MODE if !WIFI_NRF7000
-	default NRF70_SCAN_ONLY if WIFI_NRF7000
+	default NRF70_SYSTEM_MODE if !WIFI_USAGE_MODE_SCAN_ONLY


we still need a link b/w nRF7000 and WIFI_USAGE_MODE_SCAN_ONLY

This was written with the intent that WIFI_USAGE_MODE is more of a "hint" than a hard request. In that case, if WIFI_USAGE_MODE_AP is set on a nRF7000, the NRF70_OPER_MODE will fall through NRF70_SYSTEM_MODE because it isn't supported and enable NRF70_SCAN_ONLY.

If the consensus is for more explicit configuration failures, I can take a look at that.

Yeah it works fine, but I don't see any Kconfig warnings with west build -p -b nrf9160dk/nrf9160/ns samples/net/wifi/shell --shield nrf7002ek_nrf7000 --cmake-only it silently falls back to scan-only.

As I said, its currently a hint, not a hard request. Do you think it should fail to build if the driver can't support the requested mode?

At least a Kconfig warning would be good to keep the users informed.

drivers/wifi/nrf_wifi/Kconfig.nrfwifi

tests/drivers/wifi/nrf_wifi/testcase.yaml

MaochenWang1 · 2025-01-22T07:52:12Z

drivers/wifi/nxp/Kconfig.nxp

@@ -539,7 +539,7 @@ config NXP_WIFI_SOFTAP_SUPPORT
 	bool "Wi-Fi SoftAP Support"
 	select NET_DHCPV4_SERVER
 	select WIFI_NM_HOSTAPD_AP if WIFI_NM_WPA_SUPPLICANT
-	default y
+	default y if WIFI_USAGE_MODE_AP || WIFI_USAGE_MODE_STA_AP


Currently NXP_WIFI_SOFTAP_SUPPORT is default enabled for NXP wifi chip, but your change will change the logic that we have to add extra WIFI_USAGE_MODE_STA_AP into the .conf, right?
Can you keep the original config logic?

Currently NXP_WIFI_SOFTAP_SUPPORT is default enabled for NXP wifi chip, but your change will change the logic that we have to add extra WIFI_USAGE_MODE_STA_AP into the .conf, right?
Can you keep the original config logic?

This is changed by #87410 which disables AP mode by default.

Great, I will try and keep an eye on that PR and update this one (and address the file conflicts) once it is in.

github-actions · 2025-03-24T00:37:09Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

jukkar · 2025-03-28T14:57:33Z

This seems to have been fall through the cracks and become stale. @JordanYates is this still valid one, there did not seem to be too much resistance against it?

JordanYates · 2025-03-30T04:30:59Z

This seems to have been fall through the cracks and become stale. @JordanYates is this still valid one, there did not seem to be too much resistance against it?

Yes, the desire to set what WiFi mode the application wants from the application is still valid.
I have rebased and addressed the file conflicts.

jukkar · 2025-04-08T10:37:05Z

drivers/wifi/nxp/Kconfig.nxp

@@ -539,7 +539,7 @@ config NXP_WIFI_SOFTAP_SUPPORT
 	bool "Wi-Fi SoftAP Support"
 	select NET_DHCPV4_SERVER
 	select WIFI_NM_HOSTAPD_AP if WIFI_NM_WPA_SUPPLICANT
-	default y
+	default y if WIFI_USAGE_MODE_AP || WIFI_USAGE_MODE_STA_AP


Currently NXP_WIFI_SOFTAP_SUPPORT is default enabled for NXP wifi chip, but your change will change the logic that we have to add extra WIFI_USAGE_MODE_STA_AP into the .conf, right?
Can you keep the original config logic?

This is changed by #87410 which disables AP mode by default.

krish2718 · 2025-04-09T10:25:46Z

drivers/wifi/Kconfig

+	bool "Wi-Fi interface acts as an Access Point"
+
+config WIFI_USAGE_MODE_STA_AP
+	bool "Wi-Fi interface acts as an Access Point and Station"


Suggested change

bool "Wi-Fi interface acts as an Access Point and Station"

bool "Wi-Fi interface(s) acts as an Access Point and Station"

The `CONFIG_WIFI` symbol currently covers a number of different use-cases of Wi-Fi, primarily: * Wi-Fi AP (Broadcasting a network others can connect to) * Wi-Fi Station (Connecting to an AP + SSID scanning) * Wi-Fi AP + Station (Both the above) * Wi-Fi SSID scanning (SSID scanning only) Each of these application usages of Wi-Fi requires a different set of supporting options to operate correctly (`WPA_SUPP`, `NET_CONNECTION_MANAGER`, etc), and different opportunities for resource optimisation (System heap, buffer counts, etc). Currently, optimizing the Wi-Fi drivers depends on driver specific options, which can be challenging to find and are obviously not portable across different drivers. The addition of this choice allows applications to specify in a single Kconfig option which features of Wi-Fi they use, and enable individual Wi-Fi drivers to choose defaults based on those features. Signed-off-by: Jordan Yates <jordan@embeint.com>

Default the operation mode from the application requested Wi-Fi features, not the nRF70 part number. Signed-off-by: Jordan Yates <jordan@embeint.com>

Automatically enabled `ESP32_WIFI_AP_STA_MODE` if the application specifies it wants either feature. Signed-off-by: Jordan Yates <jordan@embeint.com>

Reduce the number of config overrides needed for the various testcases by only enabling the options if needed in the first place. Signed-off-by: Jordan Yates <jordan@embeint.com>

zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers platform: ESP32 Espressif ESP32 area: Wi-Fi Wi-Fi platform: nRF Nordic nRFx labels Jan 22, 2025

zephyrbot requested review from anangl, jaz1-nordic, jukkar, kl-cruz, Kludentwo, krish2718, LucasTambor, magp-nordic, MaochenWang1, marekmatej, masz-nordic, nika-nordic, rlubos, sachinthegreen and sylvioalves January 22, 2025 03:01

zephyrbot assigned jukkar Jan 22, 2025

JordanYates force-pushed the 250122_wifi_modes branch from 8e3e3de to 1f42b54 Compare January 22, 2025 03:12

jukkar previously approved these changes Jan 22, 2025

View reviewed changes

krish2718 reviewed Jan 22, 2025

View reviewed changes

MaochenWang1 reviewed Jan 22, 2025

View reviewed changes

JordanYates dismissed jukkar’s stale review via 70b41da January 22, 2025 08:19

JordanYates force-pushed the 250122_wifi_modes branch from 1f42b54 to 70b41da Compare January 22, 2025 08:19

github-actions bot added the Stale label Mar 24, 2025

github-actions bot removed the Stale label Mar 29, 2025

krish2718 added this to Wi-Fi Mar 29, 2025

krish2718 moved this to In Progress in Wi-Fi Mar 29, 2025

JordanYates force-pushed the 250122_wifi_modes branch from 70b41da to b9747a4 Compare March 30, 2025 04:30

jukkar previously approved these changes Apr 8, 2025

View reviewed changes

jukkar requested review from krish2718 and MaochenWang1 April 9, 2025 10:21

krish2718 previously approved these changes Apr 9, 2025

View reviewed changes

JordanYates added the DNM This PR should not be merged (Do Not Merge) label Apr 9, 2025

JordanYates added 4 commits April 17, 2025 09:54

drivers: wifi: nrf_wifi: operation mode from application request

b1ad73c

Default the operation mode from the application requested Wi-Fi features, not the nRF70 part number. Signed-off-by: Jordan Yates <jordan@embeint.com>

drivers: wifi: esp32: auto ESP32_WIFI_AP_STA_MODE

41e9162

Automatically enabled `ESP32_WIFI_AP_STA_MODE` if the application specifies it wants either feature. Signed-off-by: Jordan Yates <jordan@embeint.com>

tests: wifi: nrf_wifi: reduce config overrides

b7c8498

Reduce the number of config overrides needed for the various testcases by only enabling the options if needed in the first place. Signed-off-by: Jordan Yates <jordan@embeint.com>

JordanYates dismissed stale reviews from krish2718 and jukkar via b7c8498 April 17, 2025 00:08

JordanYates force-pushed the 250122_wifi_modes branch from b9747a4 to b7c8498 Compare April 17, 2025 00:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

drivers: wifi: options for application usage of Wi-Fi #84353

drivers: wifi: options for application usage of Wi-Fi #84353

JordanYates commented Jan 22, 2025

Uh oh!

krish2718 Jan 22, 2025

Uh oh!

JordanYates Jan 22, 2025

Uh oh!

krish2718 Jan 22, 2025

Uh oh!

JordanYates Jan 22, 2025

Uh oh!

krish2718 Jan 22, 2025

Uh oh!

Uh oh!

Uh oh!

MaochenWang1 Jan 22, 2025

Uh oh!

jukkar Apr 8, 2025 •

edited

Loading

Uh oh!

JordanYates Apr 9, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

jukkar commented Mar 28, 2025

Uh oh!

JordanYates commented Mar 30, 2025

Uh oh!

jukkar Apr 8, 2025 •

edited

Loading

Uh oh!

krish2718 Apr 9, 2025

Uh oh!

Uh oh!

	bool "Wi-Fi interface acts as an Access Point and Station"
	bool "Wi-Fi interface(s) acts as an Access Point and Station"

drivers: wifi: options for application usage of Wi-Fi #84353

Are you sure you want to change the base?

drivers: wifi: options for application usage of Wi-Fi #84353

Conversation

JordanYates commented Jan 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jukkar Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

jukkar commented Mar 28, 2025

Uh oh!

JordanYates commented Mar 30, 2025

Uh oh!

jukkar Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jukkar Apr 8, 2025 •

edited

Loading

jukkar Apr 8, 2025 •

edited

Loading