Skip to content

Create dedicated heap for supplicant #83497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Create dedicated heap for supplicant #83497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aecb8f3
modules: hostap: Define dedicated heap for supplicant
rado17 Dec 30, 2024
82317e4
manifest: hostap: Pull in changes for dedicated heap
rado17 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/hostap/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ config WIFI_NM_WPA_SUPPLICANT

if WIFI_NM_WPA_SUPPLICANT

config HEAP_MEM_POOL_ADD_SIZE_HOSTAP
config WIFI_NM_WPA_SUPPLICANT_HEAP
Copy link
Contributor

@MaochenWang1 MaochenWang1 Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dedicated heap maybe an kconfig option that default not enabled?
And default still uses HEAP_MEM_POOL_ADD_SIZE_HOSTAP.
This change may has side effect on other chips, like you said, current heap is across various subsystems.

Copy link
Contributor Author

@rado17 rado17 Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAP_MEM_POOL_ADD_SIZE_HOSTAP will not be available after this change. Since the memory reserved by heap is same as what is being suggested by HEAP_MEM_POOL_ADD_SIZE_HOSTAP, I think it should not affect other subsystems.

Copy link
Contributor

@MaochenWang1 MaochenWang1 Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean this dedicated heap is an kconfig option that default disabled, and default use the original way for malloc.
If your chip needs this dedicate heap feature, then you can enable it in the user conf.

int "Dedicated memory pool for wpa_supplicant"
def_int 85000 if WIFI_NM_WPA_SUPPLICANT_CRYPTO_ENTERPRISE && !MBEDTLS_ENABLE_HEAP
def_int 85000 if WIFI_NM_HOSTAPD_AP
def_int 40000 if WIFI_NM_WPA_SUPPLICANT_AP
Expand Down
2 changes: 1 addition & 1 deletion west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ manifest:
- hal
- name: hostap
path: modules/lib/hostap
revision: e31fa6764a920623202b74e85e3848903351cdcb
revision: pull/74/head
- name: liblc3
revision: bb85f7dde4195bfc0fca9e9c7c2eed0f8694203c
path: modules/lib/liblc3
Expand Down
Loading