Skip to content

Conversation

@rado17
Copy link
Contributor

@rado17 rado17 commented Jan 2, 2025

Create dedicated heap for supplicant operations. Currently, WPA supplicant uses the k_malloc, which is shared across various subsystems, and we cannot enforce a minimum availability. Using a dedicated HEAP that can be pre-allocated solves this by always having necessary memory .

@zephyrbot
Copy link

zephyrbot commented Jan 2, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hostap zephyrproject-rtos/hostap@e31fa67 zephyrproject-rtos/hostap#74 zephyrproject-rtos/hostap#74/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hostap DNM This PR should not be merged (Do Not Merge) labels Jan 2, 2025
@rado17 rado17 force-pushed the supplicant_dedicated_heap branch from 7fbd7c0 to af19b47 Compare January 2, 2025 10:36
Create dedicated heap for supplicant operations and define
the heap size.

Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dedicated heap maybe an kconfig option that default not enabled?
And default still uses HEAP_MEM_POOL_ADD_SIZE_HOSTAP.
This change may has side effect on other chips, like you said, current heap is across various subsystems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAP_MEM_POOL_ADD_SIZE_HOSTAP will not be available after this change. Since the memory reserved by heap is same as what is being suggested by HEAP_MEM_POOL_ADD_SIZE_HOSTAP, I think it should not affect other subsystems.

Copy link
Contributor

@MaochenWang1 MaochenWang1 Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean this dedicated heap is an kconfig option that default disabled, and default use the original way for malloc.
If your chip needs this dedicate heap feature, then you can enable it in the user conf.

@rado17 rado17 force-pushed the supplicant_dedicated_heap branch from af19b47 to 31ac5b2 Compare January 2, 2025 10:49
Pull in changes for dedicated heap for supplicant operations.

Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
@rado17 rado17 force-pushed the supplicant_dedicated_heap branch from 31ac5b2 to 82317e4 Compare January 2, 2025 11:25
@fabiobaltieri fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025
@github-actions
Copy link

github-actions bot commented Apr 6, 2025

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 6, 2025
@github-actions github-actions bot closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Wi-Fi Wi-Fi DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hostap Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants