-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Create dedicated heap for supplicant #83497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
7fbd7c0 to
af19b47
Compare
Create dedicated heap for supplicant operations and define the heap size. Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
modules/hostap/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dedicated heap maybe an kconfig option that default not enabled?
And default still uses HEAP_MEM_POOL_ADD_SIZE_HOSTAP.
This change may has side effect on other chips, like you said, current heap is across various subsystems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HEAP_MEM_POOL_ADD_SIZE_HOSTAP will not be available after this change. Since the memory reserved by heap is same as what is being suggested by HEAP_MEM_POOL_ADD_SIZE_HOSTAP, I think it should not affect other subsystems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean this dedicated heap is an kconfig option that default disabled, and default use the original way for malloc.
If your chip needs this dedicate heap feature, then you can enable it in the user conf.
af19b47 to
31ac5b2
Compare
Pull in changes for dedicated heap for supplicant operations. Signed-off-by: Ravi Dondaputi <ravi.dondaputi@nordicsemi.no>
31ac5b2 to
82317e4
Compare
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Create dedicated heap for supplicant operations. Currently, WPA supplicant uses the k_malloc, which is shared across various subsystems, and we cannot enforce a minimum availability. Using a dedicated HEAP that can be pre-allocated solves this by always having necessary memory .