Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: L2CAP: Set NULL callback for PDUs #76489

Commits on Jul 30, 2024

  1. Bluetooth: host: add more info to conn.c log

    Print user_data and callback pointers.
    
    Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
    jori-nordic committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9130596 View commit details
    Browse the repository at this point in the history
  2. Bluetooth: allow compiling host with CONFIG_NO_RUNTIME_CHECKS

    Werror fails the build on that function.
    
    Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
    jori-nordic committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    da71325 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Bluetooth: L2CAP: Mark user_data as owned by the stack

    Storing stuff in user_data? That's a paddlin'
    
    We have been debugging issue after issue because ownership of this
    "user" data is not clearly defined. Now it is. L2CAP owns the user_data
    field entirely, as soon as `send()` is called.
    
    Also add a warning and retval using CHECKIF.
    
    Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
    jori-nordic committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    43dea71 View commit details
    Browse the repository at this point in the history
  2. Bluetooth: adapt l2cap/userdata test

    Modify the test so it checks that user_data is used and then cleared by
    the stack.
    
    Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
    jori-nordic committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    adeebea View commit details
    Browse the repository at this point in the history
  3. Bluetooth: remove forgotten TODO

    It's already done.
    
    Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
    jori-nordic committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d728c8d View commit details
    Browse the repository at this point in the history
  4. Bluetooth: L2CAP: Set NULL callback for PDUs

    It was not being set, and thus if the user_data contained garbage from
    before, then conn.c would attempt to call that garbage.
    
    Static channels don't have this issue, as every "SDU" fits into one PDU.
    
    Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
    Co-authored-by: Huajiang Zheng <nxf88597@lsv051208.swis.nl-cdc01.nxp.com>
    jori-nordic and Huajiang Zheng committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e21a121 View commit details
    Browse the repository at this point in the history