Bluetooth: L2CAP: Set NULL callback for PDUs #76489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print user_data and callback pointers. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
jori-nordic
added
bug
zephyrbot
added
platform: nRF BSIM
zephyrbot
requested review from
Thalley,
Vudentz,
aescolar,
alwa-nordic,
asbjornsabo,
hermabe,
jhedberg,
sjanc and
theob-pro
jori-nordic
force-pushed
the
all-your-data-is-belong-to-us
branch
2 times, most recently
from
8b4da08 to
a1a0e77
Compare
Werror fails the build on that function. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
jori-nordic
force-pushed
the
all-your-data-is-belong-to-us
branch
from
a1a0e77 to
0ad4d6b
Compare
Thalley
requested changes
Jul 30, 2024
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
Missing initialization of loop variable needs to be fixed; the others are optional
Storing stuff in user_data? That's a paddlin' We have been debugging issue after issue because ownership of this "user" data is not clearly defined. Now it is. L2CAP owns the user_data field entirely, as soon as `send()` is called. Also add a warning and retval using CHECKIF. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
jori-nordic
force-pushed
the
all-your-data-is-belong-to-us
branch
2 times, most recently
from
85be2d9 to
66401f0
Compare
jori-nordic
commented
Jul 31, 2024
Contributor
Author
There was a problem hiding this comment.
this is to make sure we have many K-Frames (PDUs) to send an SDU. Since the bug was discovered with K-frames in the middle of an SDU.
Modify the test so it checks that user_data is used and then cleared by the stack. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
It's already done. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
It was not being set, and thus if the user_data contained garbage from before, then conn.c would attempt to call that garbage. Static channels don't have this issue, as every "SDU" fits into one PDU. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> Co-authored-by: Huajiang Zheng <nxf88597@lsv051208.swis.nl-cdc01.nxp.com>
jori-nordic
force-pushed
the
all-your-data-is-belong-to-us
branch
from
66401f0 to
e21a121
Compare
jhedberg
approved these changes
Jul 31, 2024
Thalley
approved these changes
Jul 31, 2024
alwa-nordic
approved these changes
Jul 31, 2024
Contributor
Author
|
Sneak peek: @alwa-nordic and I are trying to get rid of |
jori-nordic
added a commit
to jori-nordic/zephyr
that referenced
this pull request
Aug 15, 2024
When user_data is not zeroed-out, the API returns an error. Downgrade the API error to a warning log instead. Introducing this check (zephyrproject-rtos#76489) broke a few PTS tests, as user_data is not initialized by `net_buf_alloc()`. Doing so is in discussion: zephyrproject-rtos#77088 Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
nashif
pushed a commit
that referenced
this pull request
Aug 19, 2024
When user_data is not zeroed-out, the API returns an error. Downgrade the API error to a warning log instead. Introducing this check (#76489) broke a few PTS tests, as user_data is not initialized by `net_buf_alloc()`. Doing so is in discussion: #77088 Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
zephyrbot
pushed a commit
that referenced
this pull request
Aug 19, 2024
When user_data is not zeroed-out, the API returns an error. Downgrade the API error to a warning log instead. Introducing this check (#76489) broke a few PTS tests, as user_data is not initialized by `net_buf_alloc()`. Doing so is in discussion: #77088 Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit 6fa6c4c)
Chenhongren
pushed a commit
to Chenhongren/zephyr
that referenced
this pull request
Aug 29, 2024
When user_data is not zeroed-out, the API returns an error. Downgrade the API error to a warning log instead. Introducing this check (zephyrproject-rtos#76489) broke a few PTS tests, as user_data is not initialized by `net_buf_alloc()`. Doing so is in discussion: zephyrproject-rtos#77088 (cherry picked from commit 6fa6c4c) Original-Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> GitOrigin-RevId: 6fa6c4c Cr-Build-Id: 8739091610579900001 Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8739091610579900001 Copybot-Job-Name: zephyr-main-copybot-downstream Change-Id: Ic115fe0bdfe6595a874c7782cd8385c49f99405c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5799351 Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> Reviewed-by: Eric Yilun Lin <yllin@google.com> Commit-Queue: Eric Yilun Lin <yllin@google.com>
mariucker
pushed a commit
to mariucker/zephyr
that referenced
this pull request
Dec 12, 2024
When user_data is not zeroed-out, the API returns an error. Downgrade the API error to a warning log instead. Introducing this check (zephyrproject-rtos#76489) broke a few PTS tests, as user_data is not initialized by `net_buf_alloc()`. Doing so is in discussion: zephyrproject-rtos#77088 Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
nashif
pushed a commit
that referenced
this pull request
Jan 23, 2025
When user_data is not zeroed-out, the API returns an error. Downgrade the API error to a warning log instead. Introducing this check (#76489) broke a few PTS tests, as user_data is not initialized by `net_buf_alloc()`. Doing so is in discussion: #77088 Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit 6fa6c4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not being set, and thus if the user_data contained garbage from
before, then conn.c would attempt to call that garbage.
Static channels don't have this issue, as every "SDU" fits into one PDU.
Watch the test fail:
CONFIG_NO_RUNTIME_CHECKS=ytoprj.conf