Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: Modification of IFX ADC driver to function with new platform #73748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

drivers: Modification of IFX ADC driver to function with new platform #73748

wants to merge 1 commit into from
+242 −80

Conversation

mcatee-infineon
Copy link
Contributor 

- Modification of IFX drivers for ADC functionality on newly integrated platform, cyw920829m2evk_02
- Addition of configuration files to relevant sample/test for cyw920829m2evk_02

@zephyrbot zephyrbot added area: Clock Control area: ADC Analog-to-Digital Converter (ADC) platform: Infineon Infineon Technologies AG area: Samples Samples labels Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Hello @mcatee-infineon, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

ifyall
ifyall reviewed Jun 4, 2024
View reviewed changes
drivers/adc/adc_ifx_cat1.c Outdated Show resolved Hide resolved
@decsny decsny removed their request for review June 5, 2024 14:49
ifyall
ifyall previously approved these changes Jun 5, 2024
View reviewed changes
ifyall
ifyall previously approved these changes Jun 11, 2024
View reviewed changes
@mcatee-infineon mcatee-infineon force-pushed the topic/upstream-cat1b-adc branch 2 times, most recently from 299aa45 to 8679d12 Compare June 13, 2024 17:03
ifyall
ifyall previously approved these changes Jun 13, 2024
View reviewed changes
npal-cy
npal-cy previously approved these changes Jun 13, 2024
View reviewed changes
anangl
anangl reviewed Aug 1, 2024
View reviewed changes
tests/drivers/adc/adc_api/boards/cyw920829m2evk_02.conf Outdated
@@ -0,0 +1 @@
CONFIG_TEST_USERSPACE=n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally done to avoid a fault that was occurring when running in userspace. This has now been addressed in this PR with modifications to mpu.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 1, 2024
@mcatee-infineon mcatee-infineon dismissed stale reviews from npal-cy and ifyall via 6110cff October 3, 2024 16:56
@mcatee-infineon mcatee-infineon force-pushed the topic/upstream-cat1b-adc branch 3 times, most recently from 4250753 to da21218 Compare October 3, 2024 17:21
@github-actions github-actions bot removed the Stale label Oct 4, 2024
@mcatee-infineon
drivers: Modification of IFX ADC driver to function with new platform
da6f9eb 
	- Modification of IFX drivers for ADC functionality of new
	  platform cyw920829m2evk_02
	- Addition of configuration files to relevant sample/test for
	  cyw920829m2evk_02
	- add custom mpu_regions.c file

Signed-off-by: McAtee Maxwell (CSS ICW SW MTO INT 2) <Maxwell.McAtee@infineon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anangl anangl anangl left review comments

@ifyall ifyall ifyall left review comments

@npal-cy npal-cy npal-cy left review comments

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@parthitce parthitce Awaiting requested review from parthitce

@talih0 talih0 Awaiting requested review from talih0

At least 2 approving reviews are required to merge this pull request.

Assignees

@anangl anangl

Labels
area: ADC Analog-to-Digital Converter (ADC) area: Clock Control area: Samples Samples platform: Infineon Infineon Technologies AG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcatee-infineon @anangl @ifyall @npal-cy @zephyrbot