arch: x86: avoided increments/decrements with side effects #72372
Conversation
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
jhedberg,
laurenmurphyx64,
najumon1980,
nashif and
tbursztyka
tychofrei02
force-pushed
the
misra_rule_13_3_auditable_to_main_in_arch
branch
from
5f5791d to
df92f43
Compare
|
Can you clarify why these changes fall afoul of that rule? What side effects are being prevented here? Mostly this looks like churn just designed around removing "++" operators, which seems not in keeping with the actual rule? (And also sorta Sisyphean anyway -- you'll never get this operator out of the fingers of developers committing new code.) |
|
Basically my read is that rule is designed to disallow code like |
tychofrei02
force-pushed
the
misra_rule_13_3_auditable_to_main_in_arch
branch
from
df92f43 to
c51f06c
Compare
arch/x86/core/intel64/cpu.c
Outdated
| @@ -206,7 +206,7 @@ FUNC_NORETURN void z_x86_cpu_init(struct x86_cpuboot *cpuboot) | |||
| #endif | |||
|
|
|||
| /* Enter kernel, never return */ | |||
| cpuboot->ready++; | |||
| cpuboot->ready += 1; | |||
There was a problem hiding this comment.
No value is used after increment here.
arch/x86/core/intel64/irq.c
Outdated
| for (i = 0; i < VECTORS_PER_PRIORITY; ++i, ++vector) { | ||
| const int end_vector = vector + (int) VECTORS_PER_PRIORITY; | ||
|
|
||
| for (; vector < end_vector; ++vector) { |
There was a problem hiding this comment.
No value is used after increment here; the comma operator doesn't inspect the value of its two subexpressions.
arch/x86/zefi/zefi.c
Outdated
| @@ -194,7 +195,7 @@ uintptr_t __abi efi_entry(void *img_handle, struct efi_system_table *sys_tab) | |||
| * to drain before we start banging on the same UART from the | |||
| * OS. | |||
| */ | |||
| for (volatile int i = 0; i < 50000000; i++) { | |||
| for (volatile int i = 0; i < 50000000; i += 1) { | |||
There was a problem hiding this comment.
No value is used after increment here.
- moved ++/-- before or after the value use Signed-off-by: frei tycho <tfrei@baumer.com>
tychofrei02
force-pushed
the
misra_rule_13_3_auditable_to_main_in_arch
branch
from
c51f06c to
d23d7bc
Compare
Fair enough, I removed those changes. |
Avoided increments/decrements with side effects.
Avoided more than one increment/decrement in for-loop.
This corresponds to following coding guideline:
This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
671153b