-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coding guidelines fixes migration from auditable branch back to main (forward port) #48002
Open
28 of 31 tasks
Labels
area: Coding Guidelines
Coding guidelines and style
area: MISRA-C
Enhancement
Changes/Updates/Additions to existing features
Safety
Tracked by the Safety WG
Comments
simhein
added
Enhancement
Changes/Updates/Additions to existing features
area: MISRA-C
area: Coding Guidelines
Coding guidelines and style
labels
Jul 19, 2022
This was referenced Jul 20, 2022
This was referenced Jul 21, 2022
simhein
changed the title
MISRA coding guidelines migration from auditable branch back to main
MISRA coding guidelines fixes migration from auditable branch back to main (forward port)
Nov 29, 2022
This was referenced Apr 24, 2024
This was referenced Apr 25, 2024
This was referenced Apr 26, 2024
Merged
This was referenced Apr 29, 2024
This was referenced May 7, 2024
This was referenced May 14, 2024
This was referenced Jun 3, 2024
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Coding Guidelines
Coding guidelines and style
area: MISRA-C
Enhancement
Changes/Updates/Additions to existing features
Safety
Tracked by the Safety WG
Coding guideline fixes migration from auditable branch back to main (forward port)
The actual https://docs.zephyrproject.org/latest/contribute/coding_guidelines/index.html defines a subset of MISRA-C 2012 rules.
A wide range of violations of the the projects coding guideline rules where fixed in the auditable branch (https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch) by BUGSENG (https://github.com/zephyrproject-rtos/zephyr/commits/v2.7-auditable-branch/?author=Abramo-Bagnara) and need to be brought back to the main branch so the whole project will benefit.
Migration status
The following list shows and tracks the commits which should be brought to the main branch
includes: explicit cast of destination bitwidth of left shift #71856
arch: coding guidelines: add explicit cast to void #72066
include: zephyr: coding guidelines: add explicit cast to void #72160
lib: os: coding guidelines: add explicit cast to void #72166
kernel: coding guidelines: add explicit cast to void #72165
coding guidelines: comply with MISRA C:2012 Rule 8.3 7b6cdcbClosed to duplicate PR and heavy changes in the gen_syscalls.py scripts which need to be analyzed if these functional changes has impact.scripts: ensure declarations of objects use same names and type qualifiers #71919
coding guidelines: comply with MISRA C:2012 Rule 8.3 878d433Closed to duplicate PR and heavy changes in the gen_syscalls.py scripts which need to be analyzed if these functional changes has impact.scripts: ensure declarations of objects use same names and type qualifiers #71919
Userspace: avoid to convert pointers to incomplete type using the pointer to first item #71981
kernel: avoid to convert pointers to incomplete type using the pointer to first item #71984
arch x86: added missing braces #72074
drivers: avoid to use undefined macros in #if expressions #72073
arch x86: avoid to use undefined macros in #if expressions #72076
includes: avoid to use undefined macros in #if expressions #72084
kernel: avoid to use undefined macros in #if expressions #72088
tests: avoid to use undefined macros in #if expressions #72089
kernel: made copied datatype explicit #72093
Formatting Output: made copied datatype explicit #72094
arch: avoided dead stores #72095
kernel: avoided dead stores #72099
arch: x86: corrected parameter names #74923
drivers: added requested parentheses verifying the lack of ambiguities #72126
includes: added requested parentheses verifying the lack of ambiguities #72133
kernel: added parentheses verifying the lack of ambiguities #72149
lib: added parentheses verifying the lack of ambiguities #72213
arch: avoided dead stores #72095
subsys: added parentheses verifying the lack of ambiguities #72219
drivers: added requested parentheses verifying the lack of ambiguities #72126
debug: stack: coding guidelines: cast unused arguments to void #72233
arch: x86: coding guidelines: cast unused arguments to void #72228
kernel: coding guidelines: cast unused arguments to void #72236
coding guidelines: comply with MISRA C:2012 Rule 11.9 839fa85Closed due to functional changes ( in the context of physical addresses ) and concerns of the maintainer which are described in the PR -> Justification needed.kernel: avoided unwanted null pointer if CONFIG_KERNEL_VM_BASE is 0 #72220
includes: avoid using result of an assignment operator #72223
kernel: avoid using result of an assignment operator #72226
os: avoid using result of an assignment operator #72227
arch: x86: Avoid cast between pointer to void and an arithmetic type. #72231
Formatting Output: Avoid backwards goto jump #72234
drivers: linker: added missing parenthesis #72346
drivers: added missing parenthesis #72886
include: arch: x86: added missing parenthesis #72938
include: kernel: added missing parenthesis #72941
include: logging: added missing parenthesis #73644
include: sys: added missing parenthesis #73668
include: toolchain: added missing parenthesis #73773
kernel: added missing parenthesis #73774
lib: added missing parenthesis #73775
arch: x86: added missing parenthesis #72877
arch: x86: avoided increments/decrements with side effects #72372
lib: avoided increments/decrements with side effects #72806
kernel: avoided increments/decrements with side effects #72739
lib: avoided increments/decrements with side effects #72806
tests: Made pointer parameters explicitely const where non-const pointer parameters are not needed #72417
kernel: removed redundant casts #72413
Formatting Output: avoided assignment of string literals to non-const char * #72660
arch: coding guidelines: use bool param when data nature is boolean #72675
arch: avoid mixing types #73077
arch: coding guidelines: use bool param when data nature is boolean #72675
drivers: added missing parenthesis #72886
arch: x86: added missing parenthesis #72877
include: arch: x86: added missing parenthesis #72938
include: sys: added missing parenthesis #73668
include: toolchain: added missing parenthesis #73773
kernel: added missing parenthesis #73774
lib: added missing parenthesis #73775
include: kernel: added missing parenthesis #72941
include: logging: added missing parenthesis #73644
lib: libc: make char subtractions compliant with coding guidelines #73778
kernel: avoid Boolean-to-integer type casts #73782
lib: utils: avoid Boolean-to-integer type casts #73784
lib: change controlling expressions in if/while to Boolean #73929
net: change controlling expressions in while to Boolean #73933
shell: change controlling expressions in while to Boolean #73934
testsuite: change controlling expressions in while to Boolean #73935
tracing: change controlling expressions in while to Boolean #73936
Bluetooth: Controller: Change condition in while to Boolean #73937
Suggestions
The text was updated successfully, but these errors were encountered: