debug: stack: coding guidelines: cast unused arguments to void #72233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added missing ARG_UNUSED Signed-off-by: frei tycho <tfrei@baumer.com>
Contributor
|
looks like commit message is slightly inaccurate? |
Contributor
Author
What do you mean, exactly? In the commit an argument is cast to void using the macro ARG_UNUSED. |
Contributor
oops, nevermind. Sorry, I thought ARG_UNUSED was expanding to something like |
kartben
approved these changes
May 6, 2024
nashif
approved these changes
May 7, 2024
tychofrei02
deleted the
coding_guideline_2_7_auditable_to_main_in_include/debug
branch
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing ARG_UNUSED.
This corresponds to following coding guideline:
This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
5b627ad