drivers: clock_control: stm32h7: disable PLL1 before configuring it #57337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the boot loader already switched the system clock to PLL1 we need to switch back to HSI first and disable PLL1 before we can configure PLL1. Otherwise the register writes will simply be ignored and we'll end up with an inconsistent state. Most of the code has been recycled from `clock_stm32_ll_common.c`. Signed-off-by: Sascha Silbe <sascha-pgp@se-silbe.de> Signed-off-by: Sascha Silbe <sascha-pgp@silbe.org>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @silbe, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
FRASTM
approved these changes
Apr 27, 2023
|
Thanks for review & merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the boot loader already switched the system clock to PLL1 we need to switch back to HSI first and disable PLL1 before we can configure PLL1. Otherwise the register writes will simply be ignored and we'll end up with an inconsistent state.
Most of the code has been recycled from
clock_stm32_ll_common.c.