Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: arm: gigadevice: Initial support for gd32f470ik #46894

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

duchesne9al
Copy link

@duchesne9al duchesne9al commented Jun 25, 2022

Add initial support for the GD32F470I evaluation board.

There is an open pull request to add pinctrl headers for GD32F470xx devices required for:
#include <dt-bindings/pinctrl/gd32f470i(g-i-k)xx-pinctrl.h> in gd32f470i_eval_defconfig file.

I put the compatible device GD32F450IK in the board.cmake file, GD32F470IK is not yet supported by the SEGGER JLink firmware.

Samples tested on my board:
sample/hellow_world
sample/samples/basic/blinky

Signed-off-by: Alexandre Duchesne alexandre.duchesne@rtone.fr

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor comment. please update hal sha (or pull/23/head) in west.yaml as well.

boards/arm/gd32f470i_eval/board.cmake Show resolved Hide resolved
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jun 28, 2022

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_gigadevice zephyrproject-rtos/hal_gigadevice@cc8bc14 zephyrproject-rtos/hal_gigadevice@7f15468 (main) zephyrproject-rtos/hal_gigadevice@cc8bc14c..7f15468b

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @duchesne9al,

I have a few remarks and would like know if you can provide a better photo with better framing?

soc/arm/gigadevice/gd32f4xx/Kconfig.defconfig.gd32f470 Outdated Show resolved Hide resolved
boards/arm/gd32f470i_eval/board.cmake Show resolved Hide resolved
boards/arm/gd32f470i_eval/gd32f470i_eval.dts Outdated Show resolved Hide resolved
boards/arm/gd32f470i_eval/gd32f470i_eval.yaml Outdated Show resolved Hide resolved
boards/arm/gd32f470i_eval/doc/index.rst Show resolved Hide resolved
@duchesne9al duchesne9al force-pushed the boards/gd32f470ik branch 2 times, most recently from a66ecfc to e70fdc1 Compare July 3, 2022 22:57
@zephyrbot zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Jul 3, 2022
@duchesne9al
Copy link
Author

duchesne9al commented Jul 3, 2022

Hi @duchesne9al,

I have a few remarks and would like know if you can provide a better photo with better framing?

Hi @nandojve ,

Yes the framing is not great, I tried to avoid my reflection on the LCD screen but I'll see what I can do tomorrow with the light of day :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #46894 (db3f8c1) into main (88ca3ac) will increase coverage by 0.08%.
The diff coverage is 50.00%.

❗ Current head db3f8c1 differs from pull request most recent head f723a15. Consider uploading reports for the commit f723a15 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #46894      +/-   ##
==========================================
+ Coverage   49.95%   50.03%   +0.08%     
==========================================
  Files         649      654       +5     
  Lines       81822    82087     +265     
  Branches    19283    19361      +78     
==========================================
+ Hits        40874    41074     +200     
- Misses      34150    34185      +35     
- Partials     6798     6828      +30     
Impacted Files Coverage Δ
arch/x86/core/x86_mmu.c 81.95% <0.00%> (ø)
drivers/i2c/i2c_emul.c 74.35% <100.00%> (ø)
subsys/storage/flash_map/flash_map.c 48.71% <0.00%> (-6.84%) ⬇️
subsys/testsuite/ztest/src/ztest.c 54.32% <0.00%> (-5.10%) ⬇️
subsys/portability/cmsis_rtos_v2/kernel.c 75.51% <0.00%> (-4.09%) ⬇️
subsys/storage/flash_map/flash_map_integrity.c 47.61% <0.00%> (-1.22%) ⬇️
subsys/net/lib/coap/coap_link_format.c 14.28% <0.00%> (-0.61%) ⬇️
subsys/testsuite/ztest/src/ztress.c 88.09% <0.00%> (-0.48%) ⬇️
subsys/fs/fcb/fcb.c 66.00% <0.00%> (-0.45%) ⬇️
...ubsys/bluetooth/controller/ll_sw/ull_llcp_common.c 77.40% <0.00%> (-0.20%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ca3ac...f723a15. Read the comment docs.

@duchesne9al duchesne9al force-pushed the boards/gd32f470ik branch 2 times, most recently from 1c1d2c6 to e82b0b9 Compare July 4, 2022 06:31
@duchesne9al duchesne9al requested a review from nandojve July 4, 2022 07:20
add initial support for gd32f470 SoC

Signed-off-by: Alexandre Duchesne <alexandre.duchesne@rtone.fr>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jul 4, 2022
Add initial support for gd32f470ik device and gd32f470 serie.

Signed-off-by: Alexandre Duchesne <alexandre.duchesne@rtone.fr>
Add initial support for the GD32F470I evaluation board.

Signed-off-by: Alexandre Duchesne <alexandre.duchesne@rtone.fr>
@carlescufi carlescufi merged commit 4c9f1ca into zephyrproject-rtos:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants