-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: arm: gigadevice: Initial support for gd32f470ik #46894
boards: arm: gigadevice: Initial support for gd32f470ik #46894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one minor comment. please update hal sha (or pull/23/head
) in west.yaml as well.
750fad1
to
a4915fb
Compare
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
d7b30a4
to
30b9646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @duchesne9al,
I have a few remarks and would like know if you can provide a better photo with better framing?
a66ecfc
to
e70fdc1
Compare
Hi @nandojve , Yes the framing is not great, I tried to avoid my reflection on the LCD screen but I'll see what I can do tomorrow with the light of day :) |
e70fdc1
to
f723a15
Compare
Codecov Report
@@ Coverage Diff @@
## main #46894 +/- ##
==========================================
+ Coverage 49.95% 50.03% +0.08%
==========================================
Files 649 654 +5
Lines 81822 82087 +265
Branches 19283 19361 +78
==========================================
+ Hits 40874 41074 +200
- Misses 34150 34185 +35
- Partials 6798 6828 +30
Continue to review full report at Codecov.
|
1c1d2c6
to
e82b0b9
Compare
add initial support for gd32f470 SoC Signed-off-by: Alexandre Duchesne <alexandre.duchesne@rtone.fr>
e82b0b9
to
dd11116
Compare
dd11116
to
d468d6a
Compare
d468d6a
to
783b395
Compare
Add initial support for gd32f470ik device and gd32f470 serie. Signed-off-by: Alexandre Duchesne <alexandre.duchesne@rtone.fr>
Add initial support for the GD32F470I evaluation board. Signed-off-by: Alexandre Duchesne <alexandre.duchesne@rtone.fr>
783b395
to
ee0c11c
Compare
Add initial support for the GD32F470I evaluation board.
There is an open pull request to add pinctrl headers for GD32F470xx devices required for:
#include <dt-bindings/pinctrl/gd32f470i(g-i-k)xx-pinctrl.h>
in gd32f470i_eval_defconfig file.I put the compatible device GD32F450IK in the board.cmake file, GD32F470IK is not yet supported by the SEGGER JLink firmware.
Samples tested on my board:
sample/hellow_world
sample/samples/basic/blinky
Signed-off-by: Alexandre Duchesne alexandre.duchesne@rtone.fr