twister: add -Werror to CMAKE_AFLAGS #41706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing shows cmake is invoked directly, not through a shell. Fixes commit 5092541 ("sanitycheck: disable erroring on warnings"). Note EXTRA_AFLAGS was quoted only on the left side! Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This reports the warning fixed in commit 61fe69d ("sys: device_mmio.h replace <toolchain/common.h> with <toolchain.h>") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This was referenced Jan 11, 2022
Contributor
Author
|
Throw-away test PR #41701 has a revert to demo this CMAKE_AFLAGS addition. |
marc-hb
requested review from
SebastianBoe,
carlescufi,
dcpleung,
galak,
jackrosenthal,
sjg20,
stephanosio and
tejlmand
SebastianBoe
approved these changes
Jan 11, 2022
Contributor
SebastianBoe
left a comment
SebastianBoe
left a comment
There was a problem hiding this comment.
Good to have warnings in assembly also enforced in CI.
stephanosio
approved these changes
Jan 11, 2022
carlescufi
approved these changes
Jan 11, 2022
PerMac
approved these changes
Jan 11, 2022
dcpleung
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reports the warning fixed in commit 61fe69d ("sys:
device_mmio.h replace <toolchain/common.h> with <toolchain.h>")
Signed-off-by: Marc Herbert marc.herbert@intel.com