sanitycheck: disable erroring on warnings #26911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--warnings-as-errors was basically doing nothing, it is the default. Replace this with an option to disable erroring on warning: -W, --disable-warnings-as-errors Fixes zephyrproject-rtos#26910 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
sanitycheck/warnings
branch
from
2f49d12 to
aab4537
Compare
github-actions
bot
added
the
area: Sanitycheck
Contributor
|
tested and working for me. |
galak
approved these changes
Jul 16, 2020
MaureenHelm
approved these changes
Jul 17, 2020
marc-hb
reviewed
Jan 11, 2022
| f'-B{self.build_dir}', | ||
| f'-S{self.source_dir}', | ||
| f'-DEXTRA_CFLAGS="{cflags}"', | ||
| f'-DEXTRA_AFLAGS="{aflags}', |
Contributor
There was a problem hiding this comment.
This quoting did not work for me. Fix submitted in #41706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--warnings-as-errors was basically doing nothing, it is the default.
Replace this with an option to disable erroring on warning:
-W, --disable-warnings-as-errors
Fixes #26910