Linker: introduce boot and pinned regions #34717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: API
dcpleung
force-pushed
the
linker_pinned_sections
branch
from
e134422
to
ebf220a
Compare
dcpleung
requested review from
aasthagr,
andyross,
carlescufi,
galak,
jenmwms,
jhedberg,
MaureenHelm and
nashif
as code owners
zephyrbot
added
area: Base OS
dcpleung
force-pushed
the
linker_pinned_sections
branch
from
ebf220a
to
9c315b0
Compare
|
@dcpleung can you rebase? |
dcpleung
force-pushed
the
linker_pinned_sections
branch
from
9c315b0
to
6b8f105
Compare
|
Rebased |
jenmwms
approved these changes
May 7, 2021
ceolin
approved these changes
May 7, 2021
jhedberg
approved these changes
May 8, 2021
andyross
approved these changes
May 10, 2021
This is similar to Z_GENERIC_SECTION() but the resulting section name has a period as prefix. This eases the need to create a section name macro for both assembly and C. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
The generic version of SECTION_VAR() is adding an extra space during expansion before second argument (e.g. SECTION_VAR(section, variable) => ".section. variable" instead of ".section.variable") which would result in build error. So remove the "##" in macro to fix this, and now it will also behave the same as SECTION_FUNC(). Signed-off-by: Daniel Leung <daniel.leung@intel.com>
These macros are identical except the specified linker region. So refactor them. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
There is exactly one function being defined with TEXT_START macro so the x86-32 __start can appear at the beginning of text section. Since no one else is using it, better remove TEXT_START to simplify things. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This adds the necessary bits for linker scripts and source code to specify which symbols are needed for boot process so they can be grouped together. One use of this is to group boot related code and data so these won't interval with other kernel and application for better caching. This is a must for demand paging as some functions and data must be available during the boot process and before the memory manager is initialized. During this time, paging cannot be used so symbols linked in virtual memory space are unavailable. This is up to the arch/SoC/board to define the sections in their linker scripts as section may need special alignment which cannot be done in common script snippets. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This adds the necessary bits for linker scripts and source code to specify which symbols need to be pinned in memory. This is needed for demand paging as some functions and data must reside in memory all the time and cannot be paged out (e.g. paging, scheduler, and interrupt routines for functionality). This is up to the arch/SoC/board to define the sections in their linker scripts as the pinned section may need special alignment which cannot be done in common script snippets. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This allows interrupt service routine to be declared with the __isr tag so they can be placed in the correct linker section. The first would be putting them into the pinned section. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Both boot and pinned regions need to be mapped and permissions set correctly. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This adds both boot and pinned sections to the linker script for ia32. This is required for enabling demand paging for kernel and data. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This updates the test to account for boot and pinned sections. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This adds to the macros for device MMIO declaration so they can be put into boot or pinned linker sections as needed. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This changes the ARCH_IRQ_CONNECT() to put the IRQ stubs into pinned linker section if needed. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This marks the functions into appropriate linker sections. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This marks the data and functions into appropriate linker sections. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This marks the data and functions into appropriate linker sections. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This marks the data and functions into appropriate linker sections. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This marks code and data within x86/ia32 so they are going to reside in boot and pinned regions. This is a step to enable demand paging for whole kernel. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This enables the kconfig options so that the board would be using boot and pinned linker sections. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This adds the tags for functions and variables so they can be put into boot/pinned sections. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
dcpleung
force-pushed
the
linker_pinned_sections
branch
from
6b8f105
to
0e903d3
Compare
marc-hb
reviewed
Jan 4, 2022
| @@ -16,6 +16,7 @@ | |||
| #define ZEPHYR_INCLUDE_SYS_DEVICE_MMIO_H | |||
|
|
|||
| #include <toolchain/common.h> | |||
| #include <linker/sections.h> | |||
There was a problem hiding this comment.
In #41555 I'm moving this #include before the previous one to fix a BUILD_ASSERT redefinition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the bits so boot and pinned regions can be specified. These regions each contains their own text, data, rodata, bss and noinit linker sections. The boot region allows grouping of data and functions that are only used during the boot process. The associated physical page frames can be re-used if so desired with paging enabled. The pinned region hosts data and functions which must always reside in physical memory, for example, page fault handling routines for demand paging. This also provides the necessary macros to specify which section to place symbols. Currently, only a few source files are using these macros. More work needs to be done to classify at least the core kernel on where each symbol belongs.