toolchain: gcc: fix extra space when using SECTION_VAR #32634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic version of SECTION_VAR() is adding an extra space when calling space before second argument (e.g. SECTION_VAR(section, variable) => ".section. variable" instead of ".section.variable") which would result in build error. So remove the "##" in macro to fix this, and now it will also behave the same as SECTION_FUNC(). Signed-off-by: Daniel Leung <daniel.leung@intel.com>
dcpleung
force-pushed
the
toolchain_fix_section_var_macro
branch
from
3e629ad to
a1d58e0
Compare
Member
Author
|
Compliance is complaining about space before colon, which is needed in this case. |
andyross
approved these changes
Feb 25, 2021
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Member
Author
|
Rolled in #34717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic version of SECTION_VAR() is adding an extra space
when calling space before second argument (e.g.
SECTION_VAR(section, variable) => ".section. variable"
instead of ".section.variable") which would result in build
error. So remove the "##" in macro to fix this, and now it
will also behave the same as SECTION_FUNC().
Signed-off-by: Daniel Leung daniel.leung@intel.com