Bluetooth: Mesh: Verify network buffer max len #31909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trond-snekvik
added
bug
trond-snekvik
requested review from
Vudentz,
jhedberg and
joerchan
as code owners
jhedberg
approved these changes
Feb 3, 2021
Member
jhedberg
left a comment
jhedberg
left a comment
There was a problem hiding this comment.
Looks fine. Btw, the Priority: label doesn't really do anything for pull requests (in that it would be considered by the formal release process), so you might want to consider opening an issue.
Contributor
Author
|
Alright, I'll open an issue then. I think this is a serious enough issue that we should ensure it goes in. |
As network_decode needs a target buffer for decoding, the max PDU length must be checked to prevent overflow on the target buffer. When receiving a proxy configuration message with excessive length, there's no previous check for this. Also pulls the NET PDU length defines out into net.h, so they can be used when defining the target buffers. Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
force-pushed
the
net_pdu_maxlen
branch
from
e9198b2 to
9a91156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As network_decode needs a target buffer for decoding, the max PDU length
must be checked to prevent overflow on the target buffer. When receiving
a proxy configuration message with excessive length, there's no previous
check for this.
Also pulls the NET PDU length defines out into net.h, so they can be
used when defining the target buffers.
Fixes #31911
Signed-off-by: Trond Einar Snekvik Trond.Einar.Snekvik@nordicsemi.no