Bluetooth: Post-upmerge bugfixes for v1.5 #457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As network_decode needs a target buffer for decoding, the max PDU length must be checked to prevent overflow on the target buffer. When receiving a proxy configuration message with excessive length, there's no previous check for this. Also pulls the NET PDU length defines out into net.h, so they can be used when defining the target buffers. Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
After #31176, the network would get stored immediately in bt_mesh_net_create, causing the address and devicekey to get stored as their zero-initialized version, as they're only being set in the bt_mesh_comp_provision call, which fires after. Fixes #32067. Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
requested review from
PavelVPV,
carlescufi,
cvinayak and
joerchan
PavelVPV
approved these changes
Feb 10, 2021
cvinayak
approved these changes
Feb 10, 2021
Contributor
Author
|
Compliance failures are all on commit title length. |
Contributor
EDIT: nvm :P |
joerchan
approved these changes
Feb 10, 2021
tejlmand
approved these changes
Feb 10, 2021
Contributor
tejlmand
left a comment
tejlmand
left a comment
There was a problem hiding this comment.
Pulls in 3 Bluetooth Mesh bugfix PRs and one controller bugfix PR from upstream:
* [zephyrproject-rtos/zephyr#32069](https://github.com/zephyrproject-rtos/zephyr/pull/32069) (merged upstream) * [zephyrproject-rtos/zephyr#31909](https://github.com/zephyrproject-rtos/zephyr/pull/31909) (merged upstream) * [zephyrproject-rtos/zephyr#32080](https://github.com/zephyrproject-rtos/zephyr/pull/32080) (pending upstream) * [zephyrproject-rtos/zephyr#32160](https://github.com/zephyrproject-rtos/zephyr/pull/32160) (pending upstream)
Note, all PRs mentioned have been merged upstream, so you may change all the commits in this PR to [nrf fromtree]
Contributor
you can still line wrap the title as it is done in other commits. Merging a PR with compliance failure causes all later PRs to fail in same way. |
tejlmand
requested changes
Feb 10, 2021
Contributor
tejlmand
left a comment
tejlmand
left a comment
There was a problem hiding this comment.
Please fix title length, so we don't end in the situation where all subsequent PRs starts to fail compliance.
… ... ... initialization Fix missing advertising PDU length initialization which prevented advertising PDU to be transmitted by Radio. This issue was reproduced when connectable undirected advertising was enabled without setting an advertising data. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no> Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
... friend msg Set app_idx and net_idx in the msg_ctx before calling bt_mesh_keys_resolve when re-encrypting friend messages, as they'll be referenced inside the function. Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
... friend Sets the sequence number when re-encrypting messages from the friend to the lpn. This is a regression from #28511. Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
trond-snekvik
force-pushed
the
mesh_downstream_ncs_1_5
branch
from
a9b0084 to
709aa11
Compare
tejlmand
approved these changes
Feb 11, 2021
This was referenced Feb 11, 2021
tejlmand
requested changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in 3 Bluetooth Mesh bugfix PRs and one controller bugfix PR from upstream: