-
Notifications
You must be signed in to change notification settings - Fork 8.3k
drivers: gpio: sifive: Fix GPIO extern interrupts #10613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: gpio: sifive: Fix GPIO extern interrupts #10613
Conversation
IRQ_CONNECT calls in the SiFive GPIO driver were misconfigured when the conversion to DeviceTree support occurred. Signed-off-by: Nathaniel Graff <nathaniel.graff@sifive.com>
Codecov Report
@@ Coverage Diff @@
## master #10613 +/- ##
=======================================
Coverage 53.19% 53.19%
=======================================
Files 211 211
Lines 25828 25828
Branches 5686 5686
=======================================
Hits 13738 13738
Misses 9781 9781
Partials 2309 2309Continue to review full report at Codecov.
|
|
Shouldn't a similar change be necessary for other external interrupt sources as well? For example zephyr/soc/riscv32/riscv-privilege/common/soc_common_irq.c Lines 14 to 32 in 4344e27
|
IRQ_CONNECT and irq_enable calls in the SiFive UART driver were misconfigured when the conversion to DeviceTree support occurred. See also: zephyrproject-rtos#10613 Signed-off-by: Sören Tempel <soeren+git@soeren-tempel.net>
IRQ_CONNECT and irq_enable calls in the SiFive UART driver were misconfigured when the conversion to DeviceTree support occurred. See also: #10613 Signed-off-by: Sören Tempel <soeren+git@soeren-tempel.net>
IRQ_CONNECT and irq_enable calls in the SiFive UART driver were misconfigured when the conversion to DeviceTree support occurred. See also: #10613 Signed-off-by: Sören Tempel <soeren+git@soeren-tempel.net>
IRQ_CONNECT and irq_enable calls in the SiFive UART driver were misconfigured when the conversion to DeviceTree support occurred. See also: #10613 Signed-off-by: Sören Tempel <soeren+git@soeren-tempel.net>
IRQ_CONNECT and irq_enable calls in the SiFive UART driver were misconfigured when the conversion to DeviceTree support occurred. See also: #10613 Signed-off-by: Sören Tempel <soeren+git@soeren-tempel.net>
GPIO external interrupt lines need to be offset by RISCV_MAX_GENERIC_IRQ. I missed this when I converted the SiFive GPIO driver to support DeviceTree and it broke GPIO external interrupts.