-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logs dropped with CONFIG_LOG_MIPI_SYST_USE_CATALOG=y #58476
Comments
I tried tests/subsys/logging/log_syst/ on this same platform and the test did not pass, but the results are a bit inconclusive. I will need to verify the subsys test on older Zephyr. but sharing the details still here as I know SOF is out-of-tree case. |
@dcpleung Update, I did a full biset (a bit slow as I had to find a working SOF commit pair for each bisect round) and ta-daa, the culprit is caea9dc . So it is the other commit merged in #56996 , I only tested reverting bae0a5b but not the other one. :( UPDATE: So I now tested Zephyr f0a6205 with SOF f599f6131139d068fd74da13a8fcb18ef2ed6386 |
Commit caea9dc ("logging: Use TYPE_SECTION macros for log strings") changed to use TYPE_SECTION macros for log strings. However, the data type was changed from char[] to (char *), resulting in the pointer to log strings are being put in the log_strings_area section instead of the actual strings. Fix this by reverting the data type change back to before that commit but semantically uses TYPE_SECTION_ITERABLE() by expanding it manually. Fixes zephyrproject-rtos#58476 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Commit caea9dc ("logging: Use TYPE_SECTION macros for log strings") changed to use TYPE_SECTION macros for log strings. However, the data type was changed from char[] to (char *), resulting in the pointer to log strings are being put in the log_strings_area section instead of the actual strings. Fix this by reverting the data type change back to before that commit but semantically uses TYPE_SECTION_ITERABLE() by expanding it manually. Fixes #58476 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Describe the bug
MIPI Sys-T Cat logging is not working with current Zephyr mainline. Same application works with Zephyr 3.3.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Logs are seen in backend.
Impact
Unable to use Sys-T logging.
Logs and console output
By adding debugging to
subsys/logging/log_output_syst.c
It can be seen logs reach the output handler, but are skipped as the fmt string does not fall into the catalogue section:
Environment (please complete the following information):
Additional context
Follow-up from SOF bug thesofproject/sof#7703
The text was updated successfully, but these errors were encountered: