-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Issues with using Zephyr CONFIG_LOG_MIPI_SYST_USE_CATALOG with SOF #7703
Comments
Maybe it's due to
|
Tested reverting the "logging: Use TYPE_SECTION macros" , but did not seem to help. Filed a bug now to Zephyr side for better tracking. I'll try to bisect better when I just have the chance. |
Any instructions on how to reproduce it on hardware? I have a UPX11 to test on. Meanwhile, I will try running Sys-T under QEMU to see if I can reproduce it using Zephyr's sample app. |
@dcpleung
On UP i11, you will have to install the binary to IPC4 location and enable IPC4 in kernel. See instructions (to install SOF2.5 release on TGL systems) at : The syst logs should come out with (https://github.com/thesofproject/sof/blob/main/tools/mtrace/mtrace-reader.py) For debugging, I additionally set "CONFIG_LOG_PRINTK=n" in work/sof/app/prj.conf and use the cavstool.py to observe the printk output. I'm also trying to reproduce with the Zephyr unit test for syst. I got the unit test built for TGL UP i11 -- I got it to run but test never completes and there was no output. So I might have hit the same bug, or some user-error on my part. |
Progress on both issues. One is a regression and another is missing definition in xt-clang toolchain setup ( zephyrproject-rtos/zephyr#58499 ). USE_CATALOG does require full libc support, and now one more issue is hit when using xt-clang is that the libc implemntation provided with xt-clang is not complete and build fails to link errors:
|
We now have at least RFC level solutions for all issues. Using these, I did a quick comparison of the code size impact of enabling MIPI_SYST_USE_CATALOG logging (SYST_CAT). Following is a Intel MTL build with xt-clang toolchain default params from SOF main:
This is with zephyrproject-rtos/zephyr#58757 that allows to use minimal libc with mipi-syst-lib. |
One issue solved (ability to use mipi-syst library with minimal libc now possible with Zephyr mainline). Unfortunately a new issue found on MTL where DSP crashes when catalog feature is enabled -> #7839 |
I'm happy to report the last blocking bug has been solved in mainline (just did a retest today), so we can close this. |
FYI @dcpleung finally it all works! :) |
Describe the bug
Currently SOF Zephyr builds use "TEXT" logging output by default.
One alternative to text logging is the MIPI SYS-T Catalog logging backend which is found in Zephyr upstream:
zephyrproject-rtos/zephyr#19841
https://docs.zephyrproject.org/latest/samples/subsys/logging/syst/README.html
There are currently some issues enabling this build with SOF:
To Reproduce
Add following to work/sof/app/prj.conf
And rebuild SOF. Capture log with "mtrace-reader.py" to a file "dsplog.bin" and post-process with upstream mipi-syst tools like:
systprint -c ../../work/build-tgl/zephyr/mipi_syst_collateral.xml dsplog.bin
Reproduction Rate
100%
Expected behavior
Sys-T Catalog logging can be enabled for all support logging backends.
Impact
Inability to use more effiecient standard dictionary format.
Environment
Screenshots or console output
The text was updated successfully, but these errors were encountered: