Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement symbol tables #1488

Merged
merged 3 commits into from
Apr 9, 2017
Merged

Implement symbol tables #1488

merged 3 commits into from
Apr 9, 2017

Conversation

sjinks
Copy link
Contributor

@sjinks sjinks commented Apr 9, 2017

See #1403

@Jurigag could you please take a look? Is this what you wanted?

@Jurigag
Copy link
Contributor

Jurigag commented Apr 9, 2017

Im guessing, tomorrow i will check this on phalcon if it will work too. Also is there any test for this? Cuz don't sure.

@sjinks
Copy link
Contributor Author

sjinks commented Apr 9, 2017

Yes, test/requires.zep. It created a symtable but only for PHP 5. I removed PHP 5 check, the test still passes.

@sjinks sjinks merged commit e424586 into zephir-lang:master Apr 9, 2017
@sjinks sjinks deleted the issue-1403 branch April 9, 2017 11:39
@sergeyklay
Copy link
Contributor

Looks like something went wrong. At least for PHP 7.1 (ZTS): https://travis-ci.org/phalcon/cphalcon/jobs/220252922#L1882

@sergeyklay
Copy link
Contributor

Note: when you run tests separately there is no problem

$ vendor/bin/codecept run -vvv tests/unit/Mvc/ViewTest.php
Codeception PHP Testing Framework v2.2.10
Powered by PHPUnit 4.8.35 by Sebastian Bergmann and contributors.

Unit Tests (24) ------------------------------------------------------------
Modules: Db, Asserts, Phalcon, Filesystem, \Helper\Unit
----------------------------------------------------------------------------
✔ ViewTest: Get active render path (0.05s)
✔ ViewTest: Get current render level (0.01s)
✔ ViewTest: Get registered engines (0.00s)
✔ ViewTest: Mustache engine (0.07s)
✔ ViewTest: Twig engine (0.25s)
✔ ViewTest: Mustache mixed engine (0.00s)
✔ ViewTest: Twig mixed engine (0.01s)
✔ ViewTest: Mustache mixed engine partials (0.01s)
✔ ViewTest: Twig mixed engine partials (0.01s)
✔ ViewTest: Override layout (0.00s)
✔ ViewTest: Layout and pick (0.00s)
✔ ViewTest: Missing partial (0.01s)
✔ ViewTest: Exists (0.00s)
✔ ViewTest: Standard render (0.02s)
✔ ViewTest: Override main view (0.00s)
✔ ViewTest: Rendering with partials (0.02s)
✔ ViewTest: Get render (0.01s)
✔ ViewTest: Setters and getters (0.00s)
✔ ViewTest: View param isset (0.00s)
✔ ViewTest: Disable levels (0.02s)
✔ ViewTest: Cache di (1.02s)
✔ ViewTest: View cache independency (0.01s)
✔ ViewTest: View options (1.01s)
✔ ViewTest: Issue12648 (0.01s)
----------------------------------------------------------------------------


Time: 5.09 seconds, Memory: 8.00MB
$ php -v
PHP 7.1.3 (cli) (built: Apr  9 2017 13:09:23) ( ZTS DEBUG )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.1.3, Copyright (c) 1999-2017, by Zend Technologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants