Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test for require #1428

Closed
wants to merge 1 commit into from
Closed

Conversation

Jurigag
Copy link
Contributor

@Jurigag Jurigag commented Mar 26, 2017

@Jurigag
Copy link
Contributor Author

Jurigag commented Mar 26, 2017

@sjinks well this is correctly creating same issue as in phalcon repository, though for some reason error message is different than in phalcon though i tried to make a same code.

For first i thought maybe someVariable needed to be initialized with empty array, like in phalcon repository in plain php there were some error when tried adding new array elementy to property defined as string and i thought it was related but it's not a caused, even when change someVariable to something like protected someVariable = []; problem still happens.

@Jurigag
Copy link
Contributor Author

Jurigag commented Mar 26, 2017

@sjinks just to make sure - i checked the similar code with plain php and it works fine without issue so it's not some php 7.1 change

@sjinks sjinks self-assigned this Mar 27, 2017
sjinks added a commit to sjinks/zephir that referenced this pull request Mar 27, 2017
@sjinks sjinks closed this in 48adadf Mar 27, 2017
sergeyklay added a commit that referenced this pull request Nov 18, 2018
sergeyklay added a commit that referenced this pull request Nov 18, 2018
sergeyklay added a commit that referenced this pull request Nov 19, 2018
sergeyklay added a commit that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants