Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate correct ARG_INFO when return type of method is object #2374

Closed
Jeckerson opened this issue Jul 17, 2022 · 0 comments · Fixed by #2379 or #2382
Closed

Generate correct ARG_INFO when return type of method is object #2374

Jeckerson opened this issue Jul 17, 2022 · 0 comments · Fixed by #2379 or #2382
Assignees
@Jeckerson
Labels
bug enhancement nfr New Feature Request

Comments

@Jeckerson
Copy link
Member

Currently when method returns object or nullable object, it will generate incorrect ARG_INFO (ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX) with NULL class, which is incorrect during AST parse in PHP userland.

See phalcon/cphalcon#16023
@Jeckerson Jeckerson self-assigned this Jul 17, 2022
Jeckerson added a commit that referenced this issue Aug 17, 2022
@Jeckerson
#2374 - Implement nullable object return type
53e094e
Jeckerson added a commit that referenced this issue Aug 17, 2022
@Jeckerson
#2374 - Add ext/ files
b450ec5
Jeckerson added a commit that referenced this issue Aug 17, 2022
@Jeckerson
#2374 - Force string to int
5ef3977
Jeckerson added a commit that referenced this issue Aug 17, 2022
@Jeckerson
#2374 - Update CHANGELOG.md
66413da
Jeckerson added a commit that referenced this issue Aug 17, 2022
@Jeckerson
#2374 - Make condition strict
373b23f
Jeckerson added a commit that referenced this issue Aug 17, 2022
@Jeckerson
#2374 - Fix CS
36755d1
Jeckerson added a commit that referenced this issue Aug 17, 2022
@Jeckerson
#2374 - Change assert method
98e103c
@Jeckerson Jeckerson linked a pull request Aug 17, 2022 that will close this issue
#2374 - Implement nullable object return type #2379
Merged
3 tasks
Jeckerson added a commit that referenced this issue Aug 18, 2022
@Jeckerson
Merge pull request #2379 from zephir-lang/#2374-object-arg-info
c90b05d 
#2374 - Implement nullable object return type
@Jeckerson Jeckerson added the nfr New Feature Request label Aug 18, 2022
@Jeckerson Jeckerson reopened this Aug 22, 2022
Jeckerson added a commit that referenced this issue Aug 22, 2022
@Jeckerson
#2374 - Add support for object return type
c201276
Jeckerson added a commit that referenced this issue Aug 22, 2022
@Jeckerson
#2374 - Generate ext/ directory
2a27b73
@Jeckerson Jeckerson linked a pull request Aug 22, 2022 that will close this issue
#2374 - Add support for object return type #2382
Merged
3 tasks
Jeckerson added a commit that referenced this issue Aug 22, 2022
@Jeckerson
#2374 - Update CHANGELOG.md
27b663c
Jeckerson added a commit that referenced this issue Aug 22, 2022
@Jeckerson
#2374 - Extract common parts from condition
e57e2f2
Jeckerson added a commit that referenced this issue Aug 22, 2022
@Jeckerson
#2374 - Add test case
3cfa8a6
Jeckerson added a commit that referenced this issue Aug 22, 2022
@Jeckerson
Merge pull request #2382 from zephir-lang/#2374-return-type-object
717b0ce 
#2374 - Add support for `object` return type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
bug enhancement nfr New Feature Request
Projects
None yet
Milestone
No milestone
1 participant
@Jeckerson