Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2374 - Implement nullable object return type #2379

Merged
merged 7 commits into from
Aug 18, 2022
Merged

#2374 - Implement nullable object return type #2379

merged 7 commits into from
Aug 18, 2022

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Aug 17, 2022 •
edited
Loading

Hello!

  • Type: new feature

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Thanks

@Jeckerson Jeckerson self-assigned this Aug 17, 2022
@Jeckerson Jeckerson added the nfr New Feature Request label Aug 17, 2022
@Jeckerson Jeckerson marked this pull request as ready for review August 17, 2022 22:18
@Jeckerson Jeckerson linked an issue Aug 17, 2022 that may be closed by this pull request
Generate correct ARG_INFO when return type of method is object #2374
Closed
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jeckerson
Copy link
Member Author

Related phalcon/cphalcon#16023

@codecov
Copy link

codecov bot commented Aug 17, 2022 •
edited
Loading

Codecov Report

Merging #2379 (98e103c) into development (79dc763) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##             development   #2379      +/-   ##
================================================
- Coverage           7.14%   7.14%   -0.01%     
- Complexity          8627    8632       +5     
================================================
  Files                343     343              
  Lines              21919   21936      +17     
================================================
  Hits                1567    1567              
- Misses             20352   20369      +17

@Jeckerson Jeckerson merged commit c90b05d into development Aug 18, 2022
@Jeckerson Jeckerson deleted the #2374-object-arg-info branch August 18, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

@AlexNDRmac AlexNDRmac Awaiting requested review from AlexNDRmac

Assignees

@Jeckerson Jeckerson

Labels
nfr New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate correct ARG_INFO when return type of method is object
2 participants
@Jeckerson @niden