Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: "string" in globals produces an error #2308

Closed
niden opened this issue Oct 6, 2021 · 0 comments · Fixed by #2309
Closed

[BUG]: "string" in globals produces an error #2308

niden opened this issue Oct 6, 2021 · 0 comments · Fixed by #2309
Assignees
@Jeckerson
Labels
bug
Milestone
0.15.1

Comments

@niden
Copy link
Contributor

niden commented Oct 6, 2021

Related: #2280

When defining:

    "orm.resultset_prefetch_records": {
      "type": "string",
      "default": "0"
    },

in config.json and then compile, I get an error:

 [ERROR] Internal error: Unknown global type: string at                                                    
         phar:///srv/zephir/Library/Code/Builder/Struct.php:204
@niden niden added the bug label Oct 6, 2021
@Jeckerson Jeckerson self-assigned this Oct 6, 2021
Jeckerson added a commit that referenced this issue Oct 8, 2021
@Jeckerson
#2308 - Fix support of string type in struct globals
59336dd
@Jeckerson Jeckerson added this to the 0.15.1 milestone Oct 8, 2021
Jeckerson added a commit that referenced this issue Oct 8, 2021
@Jeckerson
#2308 - Update CHANGELOG.md
0c0fdfa
Jeckerson added a commit that referenced this issue Oct 8, 2021
@Jeckerson
#2308 - Refactor CompilerFileFactory class
4ce4cda
Jeckerson added a commit that referenced this issue Oct 8, 2021
@Jeckerson
Merge pull request #2309 from zephir-lang/#2308-globals-string
a51113c 
#2308 - Fix support of `string` type in struct globals
@Jeckerson Jeckerson linked a pull request Oct 8, 2021 that will close this issue
#2308 - Fix support of string type in struct globals #2309
Merged
3 tasks
@niden niden mentioned this issue Oct 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
bug
Projects
None yet
Milestone
0.15.1
Development

Successfully merging a pull request may close this issue.

#2308 - Fix support of string type in struct globals zephir-lang/zephir
2 participants
@niden @Jeckerson