Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Support for string in php.ini settings #2280

Closed
niden opened this issue Sep 13, 2021 · 0 comments · Fixed by #2303
Closed

[NFR]: Support for string in php.ini settings #2280

niden opened this issue Sep 13, 2021 · 0 comments · Fixed by #2303
Assignees
@Jeckerson
Labels
Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details nfr New Feature Request
Milestone
0.15.0

Comments

@niden
Copy link
Contributor

niden commented Sep 13, 2021

Currently php.ini settings only allow a handful of types such as hash, bool, int etc. There is also a filter that will not allow the types to be shown on phpinfo()

We can add support for string so as to allow more flexibility for php.ini options.

Related : phalcon/cphalcon#15269

Possible areas to change:
https://github.com/zephir-lang/zephir/blob/development/Library/Code/Builder/Struct.php#L185
https://github.com/zephir-lang/zephir/blob/development/Library/Compiler.php#L1406
@niden niden added the nfr New Feature Request label Sep 13, 2021
@niden niden mentioned this issue Sep 13, 2021
Closed
@Jeckerson Jeckerson added this to the 0.15.0 milestone Oct 3, 2021
@Jeckerson Jeckerson added the Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details label Oct 3, 2021
@Jeckerson Jeckerson self-assigned this Oct 5, 2021
Jeckerson added a commit that referenced this issue Oct 5, 2021
@Jeckerson
#2280 - Reformat config.json
e421bad
Jeckerson added a commit that referenced this issue Oct 5, 2021
@Jeckerson
#2280 - Implement TODOs
85389d1
Jeckerson added a commit that referenced this issue Oct 5, 2021
@Jeckerson
#2280 - Fix char retrieval
093afda
Jeckerson added a commit that referenced this issue Oct 5, 2021
@Jeckerson
#2280 - Implement support for string type in php.ini
8694ed2
Jeckerson added a commit that referenced this issue Oct 5, 2021
@Jeckerson
#2280 - Update CHANGELOG.md
f15c7e4
Jeckerson added a commit that referenced this issue Oct 5, 2021
@Jeckerson
#2280 - Fix code style
3dbf5b1
@Jeckerson Jeckerson linked a pull request Oct 5, 2021 that will close this issue
#2280 - Add string support in php.ini #2303
Merged
3 tasks
AlexNDRmac added a commit that referenced this issue Oct 5, 2021
@AlexNDRmac
Merge pull request #2303 from zephir-lang/#2280-php.ini-string-support
4ef01e4 
#2280 - Add `string` support in php.ini
@niden niden mentioned this issue Oct 6, 2021
Closed
@Jeckerson Jeckerson mentioned this issue Oct 9, 2021
Closed
@niden niden mentioned this issue Oct 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeckerson Jeckerson

Labels
Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details nfr New Feature Request
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

#2280 - Add string support in php.ini zephir-lang/zephir
2 participants
@niden @Jeckerson