Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Aug 8, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 8, 2025

📝 Walkthrough

Walkthrough

The version constraint for the zod package was updated to ^3.25.0 in the npm install commands within script/test-scaffold.ts and integration test files tests/integration/tests/cli/generate.test.ts and tests/integration/tests/cli/plugins.test.ts. No other changes to logic or test assertions were made.

Changes

Cohort / File(s) Change Summary
Zod Version Update in Test Scaffold
script/test-scaffold.ts
Updated the zod package version constraint in npm install command from ^3.22.4 to ^3.25.0.
Zod Version Update in CLI Integration Tests
tests/integration/tests/cli/generate.test.ts, tests/integration/tests/cli/plugins.test.ts
Changed the zod package version specification during test setup from broader or fixed versions (3, 3.21.1) to ^3.25.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c0fde5 and e8204fc.

⛔ Files ignored due to path filters (6)
  • packages/plugins/trpc/tests/projects/nuxt-trpc-v10/package.json is excluded by !**/*.json
  • packages/plugins/trpc/tests/projects/nuxt-trpc-v11/package.json is excluded by !**/*.json
  • packages/plugins/trpc/tests/projects/t3-trpc-v11/package.json is excluded by !**/*.json
  • tests/integration/test-run/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/nextjs/test-project/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/trpc/test-project/package.json is excluded by !**/*.json
📒 Files selected for processing (2)
  • tests/integration/tests/cli/generate.test.ts (1 hunks)
  • tests/integration/tests/cli/plugins.test.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: OSSAR-Scan
  • GitHub Check: build-test (20.x)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: build-test (20.x)
🔇 Additional comments (2)
tests/integration/tests/cli/plugins.test.ts (1)

73-73: All zod@^3.25.0 references are consistent—no legacy ranges found

  • Found three explicit installs, all using ^3.25.0:
    • script/test-scaffold.ts:23
    • tests/integration/tests/cli/plugins.test.ts:73
    • tests/integration/tests/cli/generate.test.ts:48
  • No other zod constraints in package.json or elsewhere.

If you’d like fully deterministic CI, you can opt to switch those three to ~3.25.0; otherwise, this is ready to merge.

tests/integration/tests/cli/generate.test.ts (1)

48-48: LGTM: install zod@^3.25.0 matches the updated test scaffolds

Consistent with the plugins test and aligns with the goal to standardize on latest 3.x ahead of v4.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/zod-to-peerdep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
script/test-scaffold.ts (1)

22-24: Make zod version configurable to test both v3 and v4 without code changes

Parametrize the zod version via an env var (or CLI arg). This enables a CI matrix (3.x and 4.x when available) and avoids future edits to this file.

Apply this diff:

 run('npm init -y');
-run(
-    'npm i --no-audit --no-fund typescript@~5.8.0 prisma@6.11.x @prisma/client@6.11.x zod@^3.25.0 decimal.js @types/node'
-);
+const zodVersion = process.env.ZOD_VERSION_SPEC ?? '^3.25.0';
+run(
+    `npm i --no-audit --no-fund typescript@~5.8.0 prisma@6.11.x @prisma/client@6.11.x zod@${zodVersion} decimal.js @types/node`
+);

Example CI matrix values:

  • ZOD_VERSION_SPEC="^3" (always latest 3.x)
  • ZOD_VERSION_SPEC="^4" (when v4 is released)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e1baedd and 4c0fde5.

⛔ Files ignored due to path filters (7)
  • packages/plugins/openapi/package.json is excluded by !**/*.json
  • packages/plugins/trpc/package.json is excluded by !**/*.json
  • packages/runtime/package.json is excluded by !**/*.json
  • packages/schema/package.json is excluded by !**/*.json
  • packages/server/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
  • pnpm-workspace.yaml is excluded by !**/*.yaml
📒 Files selected for processing (1)
  • script/test-scaffold.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: OSSAR-Scan
  • GitHub Check: dependency-review
  • GitHub Check: build-test (20.x)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: build-test (20.x)
  • GitHub Check: build-test (20.x)
🔇 Additional comments (2)
script/test-scaffold.ts (2)

23-23: LGTM: bump to latest 3.x aligns with PR objective

Updating to zod@^3.25.0 in the scaffold looks good and matches the goal to test against the latest 3.x.


23-23: No zod peerDependencies detected—no changes required

All package.json files in the repo were scanned and none declare zod under peerDependencies. Since there are no peerDependency ranges to update, no action is needed here.

@ymc9 ymc9 enabled auto-merge (squash) August 8, 2025 13:27
@ymc9 ymc9 disabled auto-merge August 8, 2025 13:27
@ymc9 ymc9 merged commit 3272280 into dev Aug 8, 2025
12 of 13 checks passed
@ymc9 ymc9 deleted the chore/zod-to-peerdep branch August 8, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants