Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Sep 8, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

📝 Walkthrough

Walkthrough

Updated Zod dependency version from ^4.0.0 to ^3.25.0 in the scaffold script and in integration test setups. No changes to logic, control flow, or public APIs.

Changes

Cohort / File(s) Change Summary
Scaffold script
script/test-scaffold.ts
Switched installed package from zod@^4.0.0 to zod@^3.25.0 in the npm install command.
Integration tests (CLI)
tests/integration/tests/cli/generate.test.ts, tests/integration/tests/cli/plugins.test.ts
Updated test setup dependencies to install zod@^3.25.0 instead of zod@^4.0.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Pre-merge checks (1 passed, 2 warnings)

❌ Failed Checks (2 warnings)
Check Name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is currently empty, providing no context, rationale, or testing instructions for the version downgrade, which hinders reviewer understanding of the change’s purpose and impact. Please provide a descriptive summary explaining why zod is being downgraded, how it affects the development and testing environments, any verification steps, and consider adding a PR template to the repository to ensure consistent future descriptions.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed Checks (1 passed)
Check Name Status Explanation
Title Check ✅ Passed The title ‘chore: downgrade zod to v3 for dev/test env’ concisely and accurately summarizes the main change by specifying the zod version downgrade for development and testing without extraneous detail.
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/downgrade-dev-zod3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
tests/integration/tests/cli/plugins.test.ts (1)

73-73: Zod v3 downgrade looks good; consider DRY + tighter range for reproducible CI.

To avoid version drift across tests and future edits, either:

  • Pin patch range, or
  • Centralize the version string.

Option A — narrower range:

-            'zod@^3.25.0',
+            'zod@~3.25.0',

Option B — centralize (use a shared constant):

-            'zod@^3.25.0',
+            `zod@${TEST_ZOD_RANGE}`,

Add once near the top (outside this hunk), or export from a shared helper:

// e.g. tests/integration/tests/cli/share.ts
export const TEST_ZOD_RANGE = process.env.TEST_ZOD_RANGE ?? '^3.25.0';
script/test-scaffold.ts (1)

23-23: Align Zod version pin in test scaffold; verify Prisma version alignment

  • Replace zod@^3.25.0 with zod@~3.25.0 in script/test-scaffold.ts for deterministic installs.
  • test-scaffold.ts pins prisma@6.11.x/@prisma/client@6.11.x, whereas plugins.test.ts uses 6.15.x—confirm whether this discrepancy is intentional or if both should be unified.
tests/integration/tests/cli/generate.test.ts (1)

48-49: Good switch to Zod v3; suggest using a shared constant to keep tests in sync.

Refactor to pull the version from a single place:

-        installPackage('prisma @prisma/client zod@^3.25.0');
+        installPackage(`prisma @prisma/client zod@${TEST_ZOD_RANGE}`);

And define/export once (outside this hunk), e.g. in ./share:

// tests/integration/tests/cli/share.ts
export const TEST_ZOD_RANGE = process.env.TEST_ZOD_RANGE ?? '^3.25.0';

This makes future major/minor flips a one-liner.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c98060 and 5f93acf.

⛔ Files ignored due to path filters (11)
  • packages/plugins/trpc/tests/projects/nuxt-trpc-v10/package.json is excluded by !**/*.json
  • packages/plugins/trpc/tests/projects/nuxt-trpc-v11/package.json is excluded by !**/*.json
  • packages/plugins/trpc/tests/projects/t3-trpc-v10/package.json is excluded by !**/*.json
  • packages/plugins/trpc/tests/projects/t3-trpc-v11/package.json is excluded by !**/*.json
  • packages/runtime/package.json is excluded by !**/*.json
  • packages/server/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
  • pnpm-workspace.yaml is excluded by !**/*.yaml
  • tests/integration/test-run/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/nextjs/test-project/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/trpc/test-project/package.json is excluded by !**/*.json
📒 Files selected for processing (3)
  • script/test-scaffold.ts (1 hunks)
  • tests/integration/tests/cli/generate.test.ts (1 hunks)
  • tests/integration/tests/cli/plugins.test.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
tests/integration/tests/cli/generate.test.ts (1)
packages/testtools/src/schema.ts (1)
  • installPackage (68-70)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: build-test (20.x)
  • GitHub Check: build-test (20.x)
  • GitHub Check: OSSAR-Scan

@ymc9 ymc9 merged commit 25da0c7 into dev Sep 9, 2025
12 checks passed
@ymc9 ymc9 deleted the chore/downgrade-dev-zod3 branch September 9, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant