Skip to content

Fix missing artifact nodes in DAG #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Fix missing artifact nodes in DAG #3727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/zenml/zen_stores/sql_zen_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5188,9 +5188,19 @@ def _get_regular_output_artifact_node(
# we want to display them as separate nodes in the
# DAG. We can therefore always create a new node
# here.
is_manual_load = (
input.type == StepRunInputArtifactType.MANUAL
)
artifact_node = helper.add_artifact_node(
node_id=helper.get_artifact_node_id(
name=input.name,
# For manual loads, the name might not be
# unique, so we use the artifact ID instead.
# We don't need to keep the name consistent
# with placeholder nodes as they don't exist
# for manual loads.
name=str(input.artifact_id)
if is_manual_load
else input.name,
step_name=step_name,
io_type=input.type,
is_input=True,
Expand Down Expand Up @@ -5221,9 +5231,20 @@ def _get_regular_output_artifact_node(
# want to merge these and instead display them
# separately in the DAG, but if that should ever change
# this would be the place to merge them.
is_manual_save = (
output.artifact_version.save_type
== ArtifactSaveType.MANUAL
)
artifact_node = helper.add_artifact_node(
node_id=helper.get_artifact_node_id(
name=output.name,
# For manual saves, the name might not be
# unique, so we use the artifact ID instead.
# We don't need to keep the name consistent
# with placeholder nodes as they don't exist
# for manual saves.
name=str(output.artifact_id)
if is_manual_save
else output.name,
step_name=step_name,
io_type=output.artifact_version.save_type,
is_input=False,
Expand Down
Loading