Switching to phpbench/phpbench based benchmarks #79
Conversation
|
@webimpress https://travis-ci.org/zendframework/zend-stdlib/jobs/285547904#L558 |
|
@froschdesign We need #74 merged before. Travis CI configuration is not the best at this moment, and it force install ( |
|
@webimpress |
.travis.yml
Outdated
| @@ -30,7 +30,8 @@ matrix: | |||
| - php: 7 | |||
| env: | |||
| - DEPS=locked | |||
| - CHECK_CS=true | |||
| - CS_CHECK=true | |||
There was a problem hiding this comment.
The variable was wrong!! Please see line 71/73.
Yeah, I know... the best if we have it in separate PR...
|
@froschdesign something definitely is wrong with this build, please note that I've moved cs-check, coverage and benchmarks to PHP 7.1 but build https://travis-ci.org/zendframework/zend-stdlib/builds/292168388?utm_source=github_status&utm_medium=notification still runs them on PHP 7! :-( |
|
@froschdesign rebased one more time, maybe now will be 💚 |
|
@webimpress |
|
Ok, so benchmarks are ok, the problem is with cs-checks, because the variable was wrong and we haven't run it at all. I'd suggest to merge #68 and fix these cs issues there. What do you think @froschdesign ? |
These needs to be updated also on PHP 7.0 because some libraries already requires PHP 7.1
|
@froschdesign Rebased, I hope last time ! |
|
💚 |
|
@webimpress |
/cc @Ocramius