Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Switch to zendframework/zend-coding-standard #68

Merged
merged 5 commits into from
Oct 24, 2017
Merged

Switch to zendframework/zend-coding-standard #68

merged 5 commits into from
Oct 24, 2017

Conversation

Koopzington
Copy link
Contributor

No description provided.

@@ -18,7 +18,8 @@
"require-dev": {
"athletic/athletic": "~0.1",
"phpunit/PHPUnit": "~4.0",
"squizlabs/php_codesniffer": "^2.6.2"
"squizlabs/php_codesniffer": "^2.6.2",
"zendframework/zend-coding-standard": "~1.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the dependency on php_codesniffer, as it's included in the zend-coding-standard. 😄

Since the coding standard enables colors per default the option is no longer needed
@michalbundyra
Copy link
Member

@froschdesign maybe this should be also merged for 3.2.0 release?

@michalbundyra
Copy link
Member

File .php_cs should be also removed and entry form .gitattributes

@froschdesign froschdesign merged commit 6494cef into zendframework:master Oct 24, 2017
@froschdesign
Copy link
Member

@Koopzington
Thanks! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants