Add support for nested query in field params

[tptrixtop]

Sorry, previous request was incorrect.

This one is correct.
Add support for multi limit in nested queries;
That fix need for nested queries inside field parameters;

In previous thread was mentioned that this is fix for that issue: #262

Fix bug for nested queries inside field parameters;

[michalbundyra]

@tptrixtop as @froschdesign mentioned before in #299 (comment) can you add test case for it, please?

[tptrixtop]

sure, i will add test for that case

[tptrixtop]

I have added tests for that case.
And 1 more fix for the same issue with offset param in nested queries;

[michalbundyra]

Please use camelCase variable names instead of underscode_separated.

What about test case suggested in #262:
autowp@95efe84
Is it a valid case? Maybe it's worth to add it here?

[michalbundyra]

Please use camelCase variable names instead of underscore_separated style.

[tptrixtop]

Yes, i think case with 1 query is valid, i will add it)

[tptrixtop]

Done. I have added test for single nested query ( few limit case #262 ).
Variable renamed from underscore to camel case.

[michalbundyra]

In general it looks good for me, I would just change offset to be different in nested and main query, to make sure nothing is mixed there.

Do we have this issue only in Mysql SelectDecorator or maybe we have similar issue also on other platforms?

[michalbundyra]

I would set here different offset, now we have the same as in the nested query, and it's possible that something is getting mixed, so to make it clear I would change the value.

[michalbundyra]

Another question also here: why these values are passed as strings, not as integers?

[michalbundyra]

Also here, I would change the offset, to be different than in nested queries.

[tptrixtop]

I have remove extra quotes and change offset & limit.

I did not check it for other platforms. Only for MySQL.
I will try to check it for other platforms)

[tptrixtop]

Done.
Limit & Offset are working in Oracle, MS SQL & IbmDb2.

Only additional fix needed in Sqlite. I have fixed it & added test for that & committed;

[michalbundyra]

I'd just to note that these methods are exactly the same as in:

zend-db/src/Sql/Platform/Mysql/SelectDecorator.php

Lines 41 to 76 in 4675b97

	protected function processLimit(
	PlatformInterface $platform,
	DriverInterface $driver = null,
	ParameterContainer $parameterContainer = null
	) {
	if ($this->limit === null && $this->offset !== null) {
	return [''];
	}
	if ($this->limit === null) {
	return;
	}
	if ($parameterContainer) {
	$paramPrefix = $this->processInfo['paramPrefix'];
	$parameterContainer->offsetSet($paramPrefix . 'limit', $this->limit, ParameterContainer::TYPE_INTEGER);
	return [$driver->formatParameterName('limit')];
	}
	return [$this->limit];
	}
	protected function processOffset(
	PlatformInterface $platform,
	DriverInterface $driver = null,
	ParameterContainer $parameterContainer = null
	) {
	if ($this->offset === null) {
	return;
	}
	if ($parameterContainer) {
	$paramPrefix = $this->processInfo['paramPrefix'];
	$parameterContainer->offsetSet($paramPrefix . 'offset', $this->offset, ParameterContainer::TYPE_INTEGER);
	return [$driver->formatParameterName('offset')];
	}
	return [$this->offset];
	}

and the difference with parent class Select is to not quote offset and limit values.
I think it's fine, for MySQL it was added in that commit: 91bfba7

[michalbundyra]

LGTM 👍 Great job @tptrixtop !

@froschdesign tests are provided now, and the fix looks good to me.

ping @ezimuel

[ezimuel]

@tptrixtop thanks!

[tptrixtop]

My pleasure, sir)