Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Update SelectDecorator.php #299

Closed
wants to merge 2 commits into from
Closed

Conversation

tptrixtop
Copy link
Contributor

@tptrixtop tptrixtop commented Jan 18, 2018

Add support for multi limit in nested queries;
That fix need for nested queries inside field parameters;

Fix bug for nested queries inside field parameters;

Provide a narrative description of what you are trying to accomplish:

Add support for multi limit in nested queries;
That fix need for nested queries inside field parameters;
@froschdesign
Copy link
Member

@tptrixtop

That fix need for nested queries inside field parameters;

We need an unit test for this fix. This allows us to understand the problem and how your fix affects the rest of the code.
At the moment the unit tests failed: https://travis-ci.org/zendframework/zend-db/jobs/330309851#L668

@autowp
Copy link
Contributor

autowp commented Jan 18, 2018

Sounds similar with #262

Add support for nested query in field params;
@tptrixtop
Copy link
Contributor Author

Sorry i have made mistake in fix, because i have moved it from my working code);

I will make correct request asap)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants