Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config location for OS/X #485

Closed
talios opened this issue May 11, 2021 · 7 comments · Fixed by #487 or #488
Closed

Config location for OS/X #485

talios opened this issue May 11, 2021 · 7 comments · Fixed by #487 or #488
Labels
config Improvements to the configuration system darwin Darwin specific suspected bug

Comments

@talios
Copy link

talios commented May 11, 2021

Is it possible to clarify the config location for OS/X - reading https://zellij.dev/documentation/configuration.html 👍

The default config directory order is as follows:

--config-dir flag
ZELLIJ_CONFIG_DIR env variable
default location
$HOME/.config/zellij
system location (/etc/zellij)

The default configuration location of your os:

Linux: /home/alice/.config/zellij
Mac: /Users/Alice/Library/Application Support/org.Zellij-Contributors.Zellij

Implies that in the absense of everything else - ~/.config/zellij/config.yaml should load - but it doesn't.

Starting with: zellij --config ~/.config/zellij/config.yaml works fine however.

@a-kenji a-kenji added suspected bug config Improvements to the configuration system labels May 11, 2021
@a-kenji
Copy link
Contributor

a-kenji commented May 11, 2021

Thank you for checking and taking the time filing a bug.
Yes that is correct - it should load from ~/.config/zellij/config.yaml in the absense of everything else.
I'll have a look at what might be causing this.

Just to confirm:

/Users/Alice/Library/Application Support/org.Zellij-Contributors.Zellij

this folder does not exist locally for you?

@a-kenji a-kenji added the darwin Darwin specific label May 11, 2021
a-kenji added a commit to a-kenji/zellij that referenced this issue May 11, 2021
closes  zellij-org#485

* fixes a regression on the config directory handling on mac
a-kenji added a commit to a-kenji/zellij that referenced this issue May 11, 2021
closes  zellij-org#485

* fixes a regression on the config directory handling on mac
@a-kenji
Copy link
Contributor

a-kenji commented May 11, 2021

@talios
I expect that this is now fixed in the current main.
Please do check if it now works for you!

@talios
Copy link
Author

talios commented May 11, 2021

@a-kenji now thats a quick response! cheers - that.... kind of worked - only - it created that default OS/X path on install and then stopped picking up the .config one: https://www.dropbox.com/s/xeejxhbr5u5qsf9/zellij-config.mp4?dl=0 for a short video showing it.

@a-kenji a-kenji reopened this May 11, 2021
@a-kenji
Copy link
Contributor

a-kenji commented May 11, 2021

@talios
Thank you very much for that detailed explanation!
That gives me a good starting point in fixing this issue.

@a-kenji
Copy link
Contributor

a-kenji commented May 11, 2021

@talios
I hope this is now fixed. Thank you for the report and the check - since I can't reproduce those errors locally.
I made the assumption that the data and config directory on darwin systems would be different from each other.

Now this shouldn't be an issue anymore. I would be happy if you would check that again!

@talios
Copy link
Author

talios commented May 11, 2021

@a-kenji seems to working on subsequent runs now fine. Excellent! I do note the task/mode bar doesn't show the remapped keys, but that'd be a different issue anyway.

@a-kenji
Copy link
Contributor

a-kenji commented May 11, 2021

@talios
Awesome, thanks for the quick feedback!
The display of remapped keys is currently being worked on in #319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Improvements to the configuration system darwin Darwin specific suspected bug
Projects
None yet
2 participants